Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relations included #33

Open
joacub opened this issue Jul 10, 2022 · 3 comments
Open

relations included #33

joacub opened this issue Jul 10, 2022 · 3 comments

Comments

@joacub
Copy link

joacub commented Jul 10, 2022

there is a little gap in the logic, what about when you are requesting something like this,

query : {
include: [UserData]
}

the include is treat in the backend doing the association and in the client that reference to the same item id so it get updated and sometimes removed, the id must be composed by the relations included so it does not get updated or deleted by other queries without this association included
.

good project by the way. I like.

@KidkArolis
Copy link
Collaborator

I see, I guess Figbird is not currently "include" aware (it's not a standard Feathers feature), wonder if we this would be possible with some kind of API for intercepting responses/events and modifying how it gets mapped to the cache. Hm.

@joacub
Copy link
Author

joacub commented Aug 2, 2022

What I’m doing to fix this is doing a incremental entities update by merging them in deep. So entity’s gets hydrated when has more data

@joacub
Copy link
Author

joacub commented Aug 2, 2022

Btw this only harkens when using get . Find gets cached by id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants