Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some components do not properly use translations system #7824

Open
konzz opened this issue Mar 28, 2025 · 2 comments
Open

Some components do not properly use translations system #7824

konzz opened this issue Mar 28, 2025 · 2 comments

Comments

@konzz
Copy link
Member

konzz commented Mar 28, 2025

Some components (i.e):

<PropertyConfigOption
label="Generated ID"
model={`template.data.commonProperties[${this.getZeroIndex()}].generatedId`}

pass a label "Generated ID" to
const PropertyConfigOption = ({ children, model, label }) => (
<Field model={model}>
<label className="property-label" htmlFor={`test${model}`}>
<input id={`test${model}`} type="checkbox" />{' '}
<Translate translationKey={label}>{label}</Translate>
</label>
{children}
</Field>
);

that is actually the translation not the key, the key is: "property generatedid"

This is wrong because it is not in our CSV files, and you won't be able to translate it in the translations form.

This also affects the updated translation script when you want to update only one language.

@aphilop
Copy link

aphilop commented Mar 28, 2025

Could this possibly also affect the upload of a file with translations for an installed language through the UI: Settings > Translations > User Interface > Import?
Because this does not seem to work. When I upload a file everything seems to work ok (I get no errors) but the terms are not updated to the provided translations.

@konzz
Copy link
Member Author

konzz commented Mar 28, 2025

As far as I know, it should only affect around 10 keys that are used in this way, no more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants