Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear why ownership matters in PI guide #303

Open
Tracked by #2357
nambrot opened this issue Feb 22, 2023 · 4 comments
Open
Tracked by #2357

Make clear why ownership matters in PI guide #303

nambrot opened this issue Feb 22, 2023 · 4 comments
Labels
dx developer experience

Comments

@nambrot
Copy link
Collaborator

nambrot commented Feb 22, 2023

  • make clear what contracts are owned
  • consider making the deployer the owner and have owner configuration be optional
  • probably link to this from the warp route
@nambrot nambrot added the dx developer experience label Feb 22, 2023
@asaj
Copy link

asaj commented Feb 22, 2023

consider making the deployer the owner and have owner configuration be optional

I like having an explicit owner? Generally not best practices to have your contracts owned by an EOA, and further more our tooling/docs encourage deploying with an insecure EOA at that.

@nambrot
Copy link
Collaborator Author

nambrot commented Feb 22, 2023

Yeah don't feel strongly about it, was just a suggestion to consider. Personally, for ownership I find it okay to be owned by the deployer first and then relinquish control later. Generally, I would optimize for reducing the surface area of configuration to get to success quicker if we can and have deployers do things after the initial success point. In any case, up whoever works on this.

@nambrot
Copy link
Collaborator Author

nambrot commented Feb 22, 2023

fwiw, the OZ erc20 wizard i believes makes the deployer the owner. Most ownable contracts default to msg.sender as the owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx developer experience
Projects
Status: No status
Development

No branches or pull requests

3 participants