-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clear why ownership matters in PI guide #303
Comments
I like having an explicit owner? Generally not best practices to have your contracts owned by an EOA, and further more our tooling/docs encourage deploying with an insecure EOA at that. |
Yeah don't feel strongly about it, was just a suggestion to consider. Personally, for ownership I find it okay to be owned by the deployer first and then relinquish control later. Generally, I would optimize for reducing the surface area of configuration to get to success quicker if we can and have deployers do things after the initial success point. In any case, up whoever works on this. |
fwiw, the OZ erc20 wizard i believes makes the deployer the owner. Most ownable contracts default to msg.sender as the owner |
The text was updated successfully, but these errors were encountered: