Estimate gas price adequately #1
Comments
matthiasgeihs
changed the title
iljabvh
pushed a commit
that referenced
this issue
Feb 2, 2024
* channel: Include shared Nonce object, incrementing the nonce of an account while the transaction is broadcast. Implement sync.Mutex, locking the nonce incrementals. In erc20_depositor.go, the depositing process is locked during the "Approve" function call with ```lockKey```. The function ```(d *ERC20Depositor) Deposit``` is renamed to `````(d *ERC20Depositor) DepositOnly` * client: To avoid timeouts caused by the added locking mechanism during ERC20 deposits, ```context.WithTimeout``` and ```twoPartyTestTimeout``` has been increased in fund_test.go and payment_test.go. * client/test: Timeouts have been increased to avoid premature timeout errors due to the locking mechanism above. --------- Signed-off-by: Ilja von Hoessle <[email protected]> Signed-off-by: sophia1ch <[email protected]>
iljabvh
added a commit
that referenced
this issue
Feb 2, 2024
Fix: Remove IncreaseAllowance & Add shared nonce (#1)
iljabvh
pushed a commit
that referenced
this issue
Feb 20, 2024
* channel: Include shared Nonce object, incrementing the nonce of an account while the transaction is broadcast. Implement sync.Mutex, locking the nonce incrementals. In erc20_depositor.go, the depositing process is locked during the "Approve" function call with ```lockKey```. The function ```(d *ERC20Depositor) Deposit``` is renamed to `````(d *ERC20Depositor) DepositOnly` * client: To avoid timeouts caused by the added locking mechanism during ERC20 deposits, ```context.WithTimeout``` and ```twoPartyTestTimeout``` has been increased in fund_test.go and payment_test.go. * client/test: Timeouts have been increased to avoid premature timeout errors due to the locking mechanism above. --------- Signed-off-by: Ilja von Hoessle <[email protected]> Signed-off-by: sophia1ch <[email protected]>
sophia1ch
added a commit
that referenced
this issue
Mar 19, 2024
* channel: Include shared Nonce object, incrementing the nonce of an account while the transaction is broadcast. Implement sync.Mutex, locking the nonce incrementals. In erc20_depositor.go, the depositing process is locked during the "Approve" function call with ```lockKey```. The function ```(d *ERC20Depositor) Deposit``` is renamed to `````(d *ERC20Depositor) DepositOnly` * client: To avoid timeouts caused by the added locking mechanism during ERC20 deposits, ```context.WithTimeout``` and ```twoPartyTestTimeout``` has been increased in fund_test.go and payment_test.go. * client/test: Timeouts have been increased to avoid premature timeout errors due to the locking mechanism above. --------- Signed-off-by: Ilja von Hoessle <[email protected]> Signed-off-by: sophia1ch <[email protected]> Signed-off-by: Sophia Koehler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Copied from hyperledger-labs/go-perun#332
Location
https://github.com/hyperledger-labs/go-perun/blob/9349d86249e080d3fc93d8d5ac82197a0c07f0d0/backend/ethereum/channel/contractbackend.go#L38
Problem
We just set a default, very high gasLimit for all calls.
Proposal
Set a more appropriate gas limit per call.
The text was updated successfully, but these errors were encountered: