You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove unnecessary target parameter from bench commands
- Remove target parameter from bench and bench-ci commands since they only accept release builds
- Update GitHub workflows to remove target parameter usage
- Simplify command signatures based on @syntactically's feedback
Co-authored-by: syntactically <[email protected]>
Copy file name to clipboardExpand all lines: Justfile
+4-6Lines changed: 4 additions & 6 deletions
Original file line number
Diff line number
Diff line change
@@ -271,14 +271,12 @@ bench-download os hypervisor cpu tag="":
271
271
tar -zxvf target/benchmarks_{{os}}_{{ hypervisor }}_{{ cpu }}.tar.gz -C target/criterion/ --strip-components=1
272
272
273
273
# Warning: compares to and then OVERWRITES the given baseline
274
-
bench-cibaselinetarget="release"features="":
275
-
@# Benchmarks should only be run with release builds for meaningful results
276
-
@if [ "{{ target }}"!="release" ]; then echo "Error: Benchmarks can only be run with release builds. Use 'just bench-ci <baseline> release' instead."; exit 1; fi
274
+
bench-cibaselinefeatures="":
275
+
@# Benchmarks are always run with release builds for meaningful results
277
276
cargo bench --profile=release {{if features =="" {''} else { "--features "+ features } }} -- --verbose --save-baseline {{ baseline }}
278
277
279
-
benchtarget="release"features="":
280
-
@# Benchmarks should only be run with release builds for meaningful results
281
-
@if [ "{{ target }}"!="release" ]; then echo "Error: Benchmarks can only be run with release builds. Use 'just bench release' instead."; exit 1; fi
278
+
benchfeatures="":
279
+
@# Benchmarks are always run with release builds for meaningful results
282
280
cargo bench --profile=release {{if features =="" {''} else { "--features "+ features } }} -- --verbose
0 commit comments