Skip to content

User Model is missing businessType constants #129

@tgraupne

Description

@tgraupne

Hello 🙂

while I was trying to implement a matching algorithm between Hyperwallet businessType values and organization types in German Law, I found that the User model is missing some businessType constants.

According to the API v4 documentation here: https://docs.hyperwallet.com/content/api/v4/resources/users/retrieve
A User of profileType = BUSINESS can have the following businessTypes:

  • CORPORATION
  • PRIVATE_COMPANY
  • PARTNERSHIP
  • NOT_FOR_PROFIT_ORGANIZATION
  • GOVERNMENT_ENTITY
  • PUBLIC_COMPANY

However, inside the User.php file, the only available constants are:
https://github.com/hyperwallet/php-sdk/blob/master/src/Hyperwallet/Model/User.php#L80

const BUSINESS_TYPE_CORPORATION = 'CORPORATION';
const BUSINESS_TYPE_PARTNERSHIP = 'PARTNERSHIP';

Am I missing something or shouldn't there be constants for the other businessTypes as well?

As another reference to a typed implementation of the sdk:

The java-sdk does have more constants:
https://github.com/hyperwallet/java-sdk/blob/master/src/main/java/com/hyperwallet/clientsdk/model/HyperwalletUser.java#L21

However, I am not sure if it is the best reference, because it also contains the value: CANADIAN_REGISTERED_CHARITY which isn't part of the API documentation anymore.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions