-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New types breaks i18next-chained-backend compatibility #58
Comments
//cc @pedrodurek |
Hey @mxsxs2, can you provide an example? |
Ohh never mind, I just got what's happening, I'll see what I can do |
i18next/i18next-browser-languageDetector#235 Will more than likely cause the same issue. |
Hey @adrai, we have some options: 2 - Remove the augmentation from all backend plugins, and it's up to users to manually implement the augmentation. Which one should we choose? |
I have no clue... (I'm not a TypeScript user) |
I think option 1 is good enough. If it is in the documentation then most people would understand it. Option 3 would be good too but I am not sure if it is worth it to introduce a single braking change just for this. Maybe if there are more in the near future? |
Can't believe this is the solution 😄 |
💥 Regression Report
The plugin overrides the backend type for i18next. This breaks existing code where developers use i18next-chained-backend
Last working version
Worked up to version: 1.1.1
Stopped working in version: 1.2.0
To Reproduce
Steps to reproduce the behavior:
Follow the guide at https://github.com/i18next/i18next-chained-backend
Expected behavior
To work as before
Your Environment
The text was updated successfully, but these errors were encountered: