Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addLocaleData functionality is removed in 2.0 and no migration docs are provided #43

Closed
givethemheller opened this issue Jul 30, 2021 · 3 comments

Comments

@givethemheller
Copy link

Previous version 1.4.X included instructions on how to add a language at runtime.

import i18next from 'i18next';
import ICU from 'i18next-icu';
import fr from 'i18next-icu/locale-data/fr';

const icu = new ICU();
icu.addLocaleData(fr);

This methodology is completely removed from the 2 release and I cannot find any instructions or migration documentation.

Can someone please provide some guidance on why this was removed, what its impact is and how to mitigate it on upgrade? Links to other documentation would be fantastic. Happy to make a PR to update docs here to help other folks out.

@jamuhl
Copy link
Member

jamuhl commented Jul 30, 2021

#42 not needed anylonger

@jamuhl jamuhl closed this as completed Jul 30, 2021
@givethemheller
Copy link
Author

@jamuhl I get that this is expected and by intent in the major, but for the sake of every engineer being tasked with dependency updates, it would be really helpful to have some documentation in the repo. A note that says "this is no longer needed" and a link to the react example seems reasonable?

@jamuhl
Copy link
Member

jamuhl commented Jul 30, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants