Skip to content

fix: remove useless orderbook fetching #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: remove useless orderbook fetching #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 8 additions & 25 deletions packages/sdk/src/lib/dataProtectorCore/processProtectedData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,37 +227,21 @@ export const processProtectedData = async <
}
return desiredPriceAppOrder;
}),
// Fetch workerpool order for App or AppWhitelist
Promise.all([
// for app
iexec.orderbook.fetchWorkerpoolOrderbook({
workerpool: vWorkerpool,
app: vApp,
dataset: vProtectedData,
requester: requester, // public orders + user specific orders
isRequesterStrict: useVoucher, // If voucher, we only want user specific orders
minTag: ['tee', 'scone'],
maxTag: ['tee', 'scone'],
category: 0,
}),
// for app whitelist
iexec.orderbook.fetchWorkerpoolOrderbook({
// Fetch workerpool order for App
iexec.orderbook
.fetchWorkerpoolOrderbook({
workerpool: vWorkerpool === ethers.ZeroAddress ? 'any' : vWorkerpool,
app: vUserWhitelist,
app: vApp,
dataset: vProtectedData,
requester: requester, // public orders + user specific orders
isRequesterStrict: useVoucher, // If voucher, we only want user specific orders
minTag: ['tee', 'scone'],
maxTag: ['tee', 'scone'],
category: 0,
}),
]).then(
([workerpoolOrderbookForApp, workerpoolOrderbookForAppWhitelist]) => {
})
.then((workerpoolOrderbook) => {
const desiredPriceWorkerpoolOrder = filterWorkerpoolOrders({
workerpoolOrders: [
...workerpoolOrderbookForApp.orders,
...workerpoolOrderbookForAppWhitelist.orders,
],
workerpoolOrders: workerpoolOrderbook.orders,
workerpoolMaxPrice: vWorkerpoolMaxPrice,
useVoucher: vUseVoucher,
userVoucher,
Expand All @@ -266,8 +250,7 @@ export const processProtectedData = async <
throw new Error('No Workerpool order found for the desired price');
}
return desiredPriceWorkerpoolOrder;
}
),
}),
]);

if (!workerpoolorder) {
Expand Down
Loading