fix: address PR review comments for E2E harness

Author: iHildy

scripts/e2e/common.py

@@ -5,6 +5,7 @@
 import json
 import os
 import random
+import shlex
 import shutil
 import socket
 import string
@@ -38,7 +39,7 @@ def run_cmd(
     timeout=timeout,
   )
   if check and result.returncode != 0:
-    cmd = ' '.join(args)
+    cmd = shlex.join(args)
     raise RuntimeError(
       f'Command failed ({result.returncode}): {cmd}\nstdout:\n{result.stdout}\nstderr:\n{result.stderr}'
     )

scripts/e2e/github_two_instance.py

@@ -361,7 +361,7 @@ def parse_gh_scopes() -> set[str]:
 
 def preflight(real_home: Path) -> tuple[str, str]:
   print_banner('Preflight')
-  require_commands(['opencode', 'gh', 'git', 'bun', 'python3'])
+  require_commands(['opencode', 'gh', 'git', 'bun', 'python3', 'pgrep'])
   scopes = parse_gh_scopes()
   required_scopes = {'repo', 'delete_repo'}
   missing_scopes = sorted(required_scopes - scopes)

src/command/sync-init.md

@@ -2,11 +2,11 @@
 description: Initialize opencode-synced configuration
 ---
 
-You MUST call the `opencode_sync` tool with `command=\"init\"`.
+You MUST call the `opencode_sync` tool with `command="init"`.
 Do not answer with plain text only.
 
 Argument handling:
-- If `$ARGUMENTS` is non-empty, pass `repo=\"$ARGUMENTS\"`.
+- If `$ARGUMENTS` is non-empty, pass `repo="$ARGUMENTS"`.
 - If `$ARGUMENTS` is empty, let the tool choose defaults.
 
 Rules:

src/command/sync-link.md

@@ -2,11 +2,11 @@
 description: Link this computer to an existing sync repo
 ---
 
-You MUST call the `opencode_sync` tool with `command=\"link\"`.
+You MUST call the `opencode_sync` tool with `command="link"`.
 Do not answer with plain text only.
 
 Argument handling:
-- If `$ARGUMENTS` is non-empty, pass `repo=\"$ARGUMENTS\"`.
+- If `$ARGUMENTS` is non-empty, pass `repo="$ARGUMENTS"`.
 - If `$ARGUMENTS` is empty, let the tool auto-discover.
 
 Reminder: