Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI testing of as-built container #70

Open
iay opened this issue Dec 3, 2024 · 0 comments
Open

Add CI testing of as-built container #70

iay opened this issue Dec 3, 2024 · 0 comments

Comments

@iay
Copy link
Owner

iay commented Dec 3, 2024

I ran into an issue (now addressed) in which the version of logbook referenced in the POM was too old: it was explicit because the version in the Shibboleth parent was even older, and I needed to override that for Spring Boot 3.3.0 (I think). However, I hit a similar problem again with Spring Boot >= 3.3.3, which needed logbook 1.5.7.

This problem wasn't picked up by the unit tests for some reason, only by invoking the container. It seems, therefore, that we need to add testing of a built container to the CI in some way, on topic branches as well as on main. I'm not sure how to do that, however, as the container does not run to termination: I suppose we'd need to build a container within CI, fire it up in the background, send it a request and confirm that worked, then terminate the container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant