Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stale rendered results #28

Open
iay opened this issue Mar 14, 2015 · 0 comments
Open

remove stale rendered results #28

iay opened this issue Mar 14, 2015 · 0 comments
Assignees

Comments

@iay
Copy link
Owner

iay commented Mar 14, 2015

The new cache system in #18 will replace old rendered results when they are queried for and the generation match, but there are a couple of situations where this will not happen:

  • an entity is referenced and then disappears from the source
  • an entity is referenced and then not queried for again

In each of these cases, the rendered result will be retained indefinitely. This probably isn't a major issue but it would make sense to sweep the cache from time to time to remove stale entries.

An alternative would be some kind of positive invalidation signal from the lower layers, or an assumption that once the generation had changed on any result then all cached results should be discarded.

@iay iay self-assigned this Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant