Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exception in refresh does not trigger degraded health #45

Open
iay opened this issue Jan 29, 2019 · 0 comments
Open

exception in refresh does not trigger degraded health #45

iay opened this issue Jan 29, 2019 · 0 comments

Comments

@iay
Copy link
Owner

iay commented Jan 29, 2019

We had a problem where (many) refresh operations were hitting Java out of heap errors (via the "uncaught exception" handler. I would have expected this to cause the health endpoint to report a DEGRADED status, but that doesn't seem to have been the case. We did see some timeouts.

A failure in the refresh operation should always result in degraded health, at least until the next successful refresh.

The reason for this isn't obvious, but it's probably related to the fact that as currently coded the degraded status is only signalled if the last successful refresh is more than two refresh intervals ago. So if, for example, every second refresh succeeds, you'll never notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant