Skip to content

Update MakeModelsCommand.php #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update MakeModelsCommand.php #45

wants to merge 1 commit into from

Conversation

flap152
Copy link

@flap152 flap152 commented May 17, 2017

Fixed case (issue #44 ) where DB connection name is not the default name for that driver. This caused errors
Code does not assume the name of the connection is the same as the driver

@flap152
Update MakeModelsCommand.php
b7035d3 
Fixed case where DB connection name is not the default name for that driver. This caused errors
Code does not assume the name of the connection is the same as the driver
flap152
flap152 commented May 17, 2017
View reviewed changes
Copy link
Author

@flap152 flap152 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing my own work I see things that could be improved:

  1. Code assumes the connection name exists in config (rather safe I think)
  2. Code assumes the connection has a "driver" property. I'm less sure about that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flap152