Add list of EEPROMs for which collection thread failed (#588)

This commit implements a list in Worker which holds the list of VPD
file paths(EEPROM paths) for which collection thread creation has
failed. After collection of all FRUs and before setting CollectionStatus
as Completed, Manager needs to process this list.
Note: Processing the list is a TODO.

Test:
```
- Install bitbaked image on Everest system.

- Check vpd-manager service status:
root@p10bmc:~# systemctl show vpd-manager -p NRestarts
NRestarts=0

- Check BMC reaches ready state:
root@p10bmc:~# obmcutil state
CurrentBMCState     : xyz.openbmc_project.State.BMC.BMCState.Ready
CurrentPowerState   : xyz.openbmc_project.State.Chassis.PowerState.On
CurrentHostState    : xyz.openbmc_project.State.Host.HostState.Running
BootProgress        : xyz.openbmc_project.State.Boot.Progress.ProgressStages.OSRunning
OperatingSystemState: xyz.openbmc_project.State.OperatingSystem.Status.OSStatus.Inactive

-Check CollectionStatus property of vpd-manager D-Bus service:
root@p10bmc:~# busctl get-property com.ibm.VPD.Manager /com/ibm/VPD/Manager com.ibm.VPD.Manager CollectionStatus
s "Completed"
```

Change-Id: I472c54861f590167d8ec767ed6ddb3992c085b0f
Signed-off-by: Souvik Roy <[email protected]>

Author: Souvik Roy

vpd-manager/include/manager.hpp

@@ -255,6 +255,12 @@ class Manager
      * @param[in] i_msg - The callback message.
      */
     void processAssetTagChangeCallback(sdbusplus::message_t& i_msg);
+
+    /**
+     * @brief API to process list of EEPROMs for which VPD collection thread
+     * creation has failed.
+     */
+    void ProcessFailedEeproms();
 #endif
 
     /**

vpd-manager/include/worker.hpp

@@ -147,6 +147,22 @@ class Worker
         return m_activeCollectionThreadCount;
     }
 
+    /**
+     * @brief API to get the list of EEPROMs for which VPD collection thread
+     * creation has failed.
+     *
+     * This API returns the list of EEPROMs for which VPD collection thread
+     * creation has failed by reference. Manager needs to process this list of
+     * EEPROMs and take appropriate action.
+     *
+     * @return reference to list of EEPROM paths for which VPD collection thread
+     * creation has failed
+     */
+    std::forward_list<std::string>& getListOfEepromPathsThreadFailed() noexcept
+    {
+        return m_failedEepromPaths;
+    }
+
   private:
     /**
      * @brief An API to parse and publish a FRU VPD over D-Bus.
@@ -526,5 +542,8 @@ class Worker
     // Counting semaphore to limit the number of threads.
     std::counting_semaphore<constants::MAX_THREADS> m_semaphore{
         constants::MAX_THREADS};
+
+    // List of EEPROM paths for which VPD collection thread creation has failed.
+    std::forward_list<std::string> m_failedEepromPaths;
 };
 } // namespace vpd

vpd-manager/src/manager.cpp

@@ -236,6 +236,8 @@ void Manager::SetTimerToDetectSVPDOnDbus()
             m_interface->set_property("CollectionStatus",
                                       std::string("InProgress"));
             m_worker->collectFrusFromJson();
+
+            ProcessFailedEeproms();
         }
     });
 }
@@ -910,4 +912,17 @@ void Manager::performVpdRecollection()
                             std::string(l_ex.what()));
     }
 }
+
+void Manager::ProcessFailedEeproms()
+{
+    if (m_worker.get() != nullptr)
+    {
+        // TODO:
+        // - iterate through list of EEPROMs for which thread creation has
+        // failed
+        // - get list of FRUs under the EEPROM
+        // - For each FRU, extract the object path and do collect single FRU
+        m_worker->getListOfEepromPathsThreadFailed().clear();
+    }
+}
 } // namespace vpd

vpd-manager/src/worker.cpp

@@ -1514,21 +1514,26 @@ void Worker::collectFrusFromJson()
                 m_activeCollectionThreadCount--;
                 m_mutex.unlock();
 
-                if (!m_activeCollectionThreadCount)
+                if (!m_activeCollectionThreadCount &&
+                    m_failedEepromPaths.empty())
                 {
                     m_isAllFruCollected = true;
                 }
             }}.detach();
         }
         catch (const std::exception& l_ex)
         {
-            // TODO: Should we re-try launching thread for this FRU?
-            EventLogger::createSyncPel(
-                types::ErrorType::InvalidVpdMessage, types::SeverityType::Alert,
-                __FILE__, __FUNCTION__, 0,
-                std::string("Failed to start collection thread for FRU :[" +
-                            vpdFilePath + "]. Error: " + l_ex.what()),
-                std::nullopt, std::nullopt, std::nullopt, std::nullopt);
+            try
+            {
+                // add vpdFilePath(EEPROM path) to failed list
+                m_failedEepromPaths.push_front(vpdFilePath);
+            }
+            catch (const std::exception& l_ex)
+            {
+                logging::logMessage(
+                    "Failed to add [" + vpdFilePath +
+                    "] to failed EEPROM list. Error: " + l_ex.what());
+            }
         }
     }
 }