vpd-tool: fix odd length keyword value

Odd length ASCII values was not taken to update keyword value for write
Keyword command, as keyword length check was present in the wrong
place.

This commit fixes the above issue, utils:: convertToBinary is updated
to fix this issue.

Output:
'''
Issue: odd length values not taking
root@p10bmc:/tmp# ./vpd-tool -O /system/chassis/motherboard -R VSYS -K WN -V "A" -w
Write keyword's value for path: /system/chassis/motherboard, Record: VSYS, Keyword: WN is failed. Exception: Write option accepts 2 digit hex numbers. (Ex. 0x1 should be given as 0x01).

With the fix:
root@p10bmc:/tmp# ./vpd-tool_oddLength -O /system/chassis/motherboard -R VSYS -K WN -V "A" -w
Data updated successfully
root@p10bmc:/tmp# vpd-tool -O /system/chassis/motherboard -R VSYS -K WN -r
{
    "/system/chassis/motherboard": {
        "WN": "A           "
    }
}
'''
Signed-off-by: Anupama B R <[email protected]>

Author: branupama

vpd-tool/include/tool_utils.hpp

@@ -312,17 +312,17 @@ inline types::BinaryVector convertToBinary(const std::string& i_value)
             "Provide a valid hexadecimal input. (Ex. 0x30313233)");
     }
 
-    if (i_value.length() % 2 != 0)
-    {
-        throw std::runtime_error(
-            "Write option accepts 2 digit hex numbers. (Ex. 0x1 "
-            "should be given as 0x01).");
-    }
-
     std::vector<uint8_t> l_binaryValue{};
 
     if (i_value.substr(0, 2).compare("0x") == constants::STR_CMP_SUCCESS)
     {
+        if (i_value.length() % 2 != 0)
+        {
+            throw std::runtime_error(
+                "Write option accepts 2 digit hex numbers. (Ex. 0x1 "
+                "should be given as 0x01).");
+        }
+
         auto l_value = i_value.substr(2);
 
         if (l_value.empty())