Skip to content

Commit ab2335c

Browse files
Fixed filter modal closing (#456)
Fixed Filter Dropdown getting closed on click of a label Co-authored-by: tiwari-nishant <[email protected]>
1 parent 7bceae4 commit ab2335c

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/components/Global/TableFilter.vue

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@
3838
:data-test-id="`tableFilter-checkbox-${value}`"
3939
class="filter-checkbox-keys"
4040
>
41-
<BDropdownItem
42-
class="filter-checkbox-labels"
41+
<span
42+
class="filter-checkbox-labels dropdown-item"
4343
@click="toggleCheckbox($event)"
4444
>
4545
{{ value }}
46-
</BDropdownItem>
46+
</span>
4747
</BFormCheckbox>
4848
</BFormCheckboxGroup>
4949
</BFormGroup>
@@ -115,7 +115,8 @@ export default {
115115
this.$emit('filter-change', { activeFilters });
116116
},
117117
toggleCheckbox(event) {
118-
const wrapper = event.target.closest(".form-check");
118+
event.preventDefault();
119+
const wrapper = event.target.closest('.form-check');
119120
if (!wrapper) return;
120121
121122
const input = wrapper.querySelector('input[type="checkbox"]');
@@ -146,4 +147,8 @@ export default {
146147
width: 100%;
147148
}
148149
}
150+
.filter-checkbox-labels.dropdown-item:active {
151+
background-color: transparent !important;
152+
color: inherit !important;
153+
}
149154
</style>

0 commit comments

Comments
 (0)