Skip to content

Conversation

@janbina
Copy link

@janbina janbina commented Apr 23, 2023

Hi guys, firstly, thanks for this library, it's very helpful for me!

However, one thing that was bothering me is that you always ask for Permission.LOCATION and there is no ability to work with coarse location.

This is especially bad since on newer android versions, user is always presented with an option to only allow coarse location. This could lead to a scenario when you call startTracking, user selects coarse location, thinking location features will start working, but they won't. And only next time you call startTracking, user is presented with another dialog to change location access from approximate to precise.

I've added an option to allowCoarseLocation with default value false, so it should be a non-breaking change. However, I really believe that true should be the default in the future, because of the aforementioned behavior.

@janbina janbina changed the base branch from master to develop April 23, 2023 23:19
@Douvi
Copy link

Douvi commented Jun 12, 2023

Hey @janbina, I like your change. Do you know when it will be merged?

@swapnil-musale
Copy link

Hey @Alex009, Do you have any plan to push this change on the master in near future?

@Alex009 Alex009 self-requested a review August 14, 2024 02:03
@mimai-hen
Copy link

Hi, I'm currently migrating my project to compose multiplatform and not being able to allow coarse location is a regression for our project. The evolution proposed by @janbina looks simple and fine @Alex009 when do you plan to merge this request on the master ? Thanks !

@mimai-hen
Copy link

@Alex009 @YokiToki is there anyone maintaining this library here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants