Get rid of _io cpp target (#322)

Author: henrij22

python/ikarus/CMakeLists.txt

@@ -15,7 +15,6 @@ set_property(
   PROPERTY LINK_LIBRARIES dunecommon ikarus
   APPEND
 )
-add_dependencies(_ikarus _io)
 
 if(SKBUILD)
   install(TARGETS _ikarus LIBRARY DESTINATION python/ikarus)

python/ikarus/_ikarus.cc

@@ -3,6 +3,7 @@
 
 #include <config.h>
 
+#include "io/io.hh"
 #include "pythonhelpers.hh"
 
 #include <dune/common/float_cmp.hh>
@@ -108,4 +109,6 @@ PYBIND11_MODULE(_ikarus, m) {
 
   pybind11::class_<NeoHooke> nh(materials, "NeoHooke");
   Ikarus::Python::registerNeoHooke(materials, nh);
+
+  addBindingsToIO();
 }

python/ikarus/io/CMakeLists.txt

@@ -2,15 +2,3 @@
 # SPDX-License-Identifier: LGPL-3.0-or-later
 
 add_python_targets(io __init__)
-
-dune_add_pybind11_module(NAME _io SOURCES _io.cc)
-
-set_property(
-  TARGET _io
-  PROPERTY LINK_LIBRARIES dunecommon ikarus
-  APPEND
-)
-
-if(SKBUILD)
-  install(TARGETS _io LIBRARY DESTINATION python/ikarus/io)
-endif()

python/ikarus/io/__init__.py

@@ -10,8 +10,6 @@
 import types
 from enum import Enum
 
-from ._io import DataTag
-
 # The list of supported dataCollectors
 DataCollector = Enum("DataCollector", ["default", "lagrange", "discontinuous", "iga"])
 

python/ikarus/io/_io.cc renamed to python/ikarus/io/io.hh

@@ -1,22 +1,26 @@
 // SPDX-FileCopyrightText: 2021-2024 The Ikarus Developers [email protected]
 // SPDX-License-Identifier: LGPL-3.0-or-later
 
-#include <config.h>
-
+/**
+ * \file io.hh
+ * \brief Additional python bindings for submodule io
+ */
 #include "../pythonhelpers.hh"
 
-#include <dune/python/common/typeregistry.hh>
 #include <dune/python/pybind11/eigen.h>
 #include <dune/python/pybind11/operators.h>
 #include <dune/python/pybind11/pybind11.h>
 
 #include <ikarus/io/vtkdatatag.hh>
 
-PYBIND11_MODULE(_io, m) {
+void addBindingsToIO() {
   namespace py = pybind11;
   using namespace pybind11::literals;
+  using namespace Ikarus;
+
+  auto io = pybind11::module::import("ikarus.io");
 
   using namespace Ikarus::Vtk;
   using namespace Ikarus;
-  ENUM_BINDINGS(DataTag);
+  ENUM_BINDINGS_WITH_MODULE(DataTag, io);
 }

python/ikarus/pythonhelpers.hh

@@ -3,9 +3,11 @@
 
 #pragma once
 
-#define ENUM_BINDINGS(Type)                                        \
-  py::enum_<Type> Type##Enum(m, #Type);                            \
+#define ENUM_BINDINGS_WITH_MODULE(Type, module)                    \
+  py::enum_<Type> Type##Enum(module, #Type);                       \
   Type Type##EnumV = Type::BEGIN;                                  \
   Ikarus::increment(Type##EnumV);                                  \
   for (; Type##EnumV != Type::END; Ikarus::increment(Type##EnumV)) \
     Type##Enum.value(toString(Type##EnumV).c_str(), Type##EnumV);
+
+#define ENUM_BINDINGS(Type) ENUM_BINDINGS_WITH_MODULE(Type, m)