Skip to content

Commit 15047b6

Browse files
authored
Merge pull request #129 from ikostan/main
Merge from master
2 parents 36e88d6 + 2063772 commit 15047b6

File tree

6 files changed

+346
-0
lines changed

6 files changed

+346
-0
lines changed
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
{
2+
"authors": [
3+
"behrtam"
4+
],
5+
"contributors": [
6+
"cmccandless",
7+
"Dog",
8+
"emerali",
9+
"ikhadykin",
10+
"N-Parsons",
11+
"olufotebig",
12+
"pheanex",
13+
"saurabhchalke",
14+
"smalley",
15+
"tqa236"
16+
],
17+
"files": {
18+
"solution": [
19+
"perfect_numbers.py"
20+
],
21+
"test": [
22+
"perfect_numbers_test.py"
23+
],
24+
"example": [
25+
".meta/example.py"
26+
]
27+
},
28+
"blurb": "Determine if a number is perfect, abundant, or deficient based on Nicomachus' (60 - 120 CE) classification scheme for positive integers.",
29+
"source": "Taken from Chapter 2 of Functional Thinking by Neal Ford.",
30+
"source_url": "https://www.oreilly.com/library/view/functional-thinking/9781449365509/"
31+
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"track":"python","exercise":"perfect-numbers","id":"21824e00793945d38db7a58a68bb9360","url":"https://exercism.org/tracks/python/exercises/perfect-numbers","handle":"myFirstCode","is_requester":true,"auto_approve":false}

perfect-numbers/HELP.md

Lines changed: 130 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,130 @@
1+
# Help
2+
3+
## Running the tests
4+
5+
We use [pytest][pytest: Getting Started Guide] as our website test runner.
6+
You will need to install `pytest` on your development machine if you want to run tests for the Python track locally.
7+
You should also install the following `pytest` plugins:
8+
9+
- [pytest-cache][pytest-cache]
10+
- [pytest-subtests][pytest-subtests]
11+
12+
Extended information can be found in our website [Python testing guide][Python track tests page].
13+
14+
15+
### Running Tests
16+
17+
To run the included tests, navigate to the folder where the exercise is stored using `cd` in your terminal (_replace `{exercise-folder-location}` below with your path_).
18+
Test files usually end in `_test.py`, and are the same tests that run on the website when a solution is uploaded.
19+
20+
Linux/MacOS
21+
```bash
22+
$ cd {path/to/exercise-folder-location}
23+
```
24+
25+
Windows
26+
```powershell
27+
PS C:\Users\foobar> cd {path\to\exercise-folder-location}
28+
```
29+
30+
<br>
31+
32+
Next, run the `pytest` command in your terminal, replacing `{exercise_test.py}` with the name of the test file:
33+
34+
Linux/MacOS
35+
```bash
36+
$ python3 -m pytest -o markers=task {exercise_test.py}
37+
==================== 7 passed in 0.08s ====================
38+
```
39+
40+
Windows
41+
```powershell
42+
PS C:\Users\foobar> py -m pytest -o markers=task {exercise_test.py}
43+
==================== 7 passed in 0.08s ====================
44+
```
45+
46+
47+
### Common options
48+
- `-o` : override default `pytest.ini` (_you can use this to avoid marker warnings_)
49+
- `-v` : enable verbose output.
50+
- `-x` : stop running tests on first failure.
51+
- `--ff` : run failures from previous test before running other test cases.
52+
53+
For additional options, use `python3 -m pytest -h` or `py -m pytest -h`.
54+
55+
56+
### Fixing warnings
57+
58+
If you do not use `pytest -o markers=task` when invoking `pytest`, you might receive a `PytestUnknownMarkWarning` for tests that use our new syntax:
59+
60+
```bash
61+
PytestUnknownMarkWarning: Unknown pytest.mark.task - is this a typo? You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/mark.html
62+
```
63+
64+
To avoid typing `pytest -o markers=task` for every test you run, you can use a `pytest.ini` configuration file.
65+
We have made one that can be downloaded from the top level of the Python track directory: [pytest.ini][pytest.ini].
66+
67+
You can also create your own `pytest.ini` file with the following content:
68+
69+
```ini
70+
[pytest]
71+
markers =
72+
task: A concept exercise task.
73+
```
74+
75+
Placing the `pytest.ini` file in the _root_ or _working_ directory for your Python track exercises will register the marks and stop the warnings.
76+
More information on pytest marks can be found in the `pytest` documentation on [marking test functions][pytest: marking test functions with attributes] and the `pytest` documentation on [working with custom markers][pytest: working with custom markers].
77+
78+
Information on customizing pytest configurations can be found in the `pytest` documentation on [configuration file formats][pytest: configuration file formats].
79+
80+
81+
### Extending your IDE or Code Editor
82+
83+
Many IDEs and code editors have built-in support for using `pytest` and other code quality tools.
84+
Some community-sourced options can be found on our [Python track tools page][Python track tools page].
85+
86+
[Pytest: Getting Started Guide]: https://docs.pytest.org/en/latest/getting-started.html
87+
[Python track tools page]: https://exercism.org/docs/tracks/python/tools
88+
[Python track tests page]: https://exercism.org/docs/tracks/python/tests
89+
[pytest-cache]:http://pythonhosted.org/pytest-cache/
90+
[pytest-subtests]:https://github.com/pytest-dev/pytest-subtests
91+
[pytest.ini]: https://github.com/exercism/python/blob/main/pytest.ini
92+
[pytest: configuration file formats]: https://docs.pytest.org/en/6.2.x/customize.html#configuration-file-formats
93+
[pytest: marking test functions with attributes]: https://docs.pytest.org/en/6.2.x/mark.html#raising-errors-on-unknown-marks
94+
[pytest: working with custom markers]: https://docs.pytest.org/en/6.2.x/example/markers.html#working-with-custom-markers
95+
96+
## Submitting your solution
97+
98+
You can submit your solution using the `exercism submit perfect_numbers.py` command.
99+
This command will upload your solution to the Exercism website and print the solution page's URL.
100+
101+
It's possible to submit an incomplete solution which allows you to:
102+
103+
- See how others have completed the exercise
104+
- Request help from a mentor
105+
106+
## Need to get help?
107+
108+
If you'd like help solving the exercise, check the following pages:
109+
110+
- The [Python track's documentation](https://exercism.org/docs/tracks/python)
111+
- The [Python track's programming category on the forum](https://forum.exercism.org/c/programming/python)
112+
- [Exercism's programming category on the forum](https://forum.exercism.org/c/programming/5)
113+
- The [Frequently Asked Questions](https://exercism.org/docs/using/faqs)
114+
115+
Should those resources not suffice, you could submit your (incomplete) solution to request mentoring.
116+
117+
Below are some resources for getting help if you run into trouble:
118+
119+
- [The PSF](https://www.python.org) hosts Python downloads, documentation, and community resources.
120+
- [The Exercism Community on Discord](https://exercism.org/r/discord)
121+
- [Python Community on Discord](https://pythondiscord.com/) is a very helpful and active community.
122+
- [/r/learnpython/](https://www.reddit.com/r/learnpython/) is a subreddit designed for Python learners.
123+
- [#python on Libera.chat](https://www.python.org/community/irc/) this is where the core developers for the language hang out and get work done.
124+
- [Python Community Forums](https://discuss.python.org/)
125+
- [Free Code Camp Community Forums](https://forum.freecodecamp.org/)
126+
- [CodeNewbie Community Help Tag](https://community.codenewbie.org/t/help)
127+
- [Pythontutor](http://pythontutor.com/) for stepping through small code snippets visually.
128+
129+
Additionally, [StackOverflow](http://stackoverflow.com/questions/tagged/python) is a good spot to search for your problem/question to see if it has been answered already.
130+
If not - you can always [ask](https://stackoverflow.com/help/how-to-ask) or [answer](https://stackoverflow.com/help/how-to-answer) someone else's question.

perfect-numbers/README.md

Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
# Perfect Numbers
2+
3+
Welcome to Perfect Numbers on Exercism's Python Track.
4+
If you need help running the tests or submitting your code, check out `HELP.md`.
5+
6+
## Instructions
7+
8+
Determine if a number is perfect, abundant, or deficient based on Nicomachus' (60 - 120 CE) classification scheme for positive integers.
9+
10+
The Greek mathematician [Nicomachus][nicomachus] devised a classification scheme for positive integers, identifying each as belonging uniquely to the categories of [perfect](#perfect), [abundant](#abundant), or [deficient](#deficient) based on their [aliquot sum][aliquot-sum].
11+
The _aliquot sum_ is defined as the sum of the factors of a number not including the number itself.
12+
For example, the aliquot sum of `15` is `1 + 3 + 5 = 9`.
13+
14+
## Perfect
15+
16+
A number is perfect when it equals its aliquot sum.
17+
For example:
18+
19+
- `6` is a perfect number because `1 + 2 + 3 = 6`
20+
- `28` is a perfect number because `1 + 2 + 4 + 7 + 14 = 28`
21+
22+
## Abundant
23+
24+
A number is abundant when it is less than its aliquot sum.
25+
For example:
26+
27+
- `12` is an abundant number because `1 + 2 + 3 + 4 + 6 = 16`
28+
- `24` is an abundant number because `1 + 2 + 3 + 4 + 6 + 8 + 12 = 36`
29+
30+
## Deficient
31+
32+
A number is deficient when it is greater than its aliquot sum.
33+
For example:
34+
35+
- `8` is a deficient number because `1 + 2 + 4 = 7`
36+
- Prime numbers are deficient
37+
38+
## Task
39+
40+
Implement a way to determine whether a given number is [perfect](#perfect).
41+
Depending on your language track, you may also need to implement a way to determine whether a given number is [abundant](#abundant) or [deficient](#deficient).
42+
43+
[nicomachus]: https://en.wikipedia.org/wiki/Nicomachus
44+
[aliquot-sum]: https://en.wikipedia.org/wiki/Aliquot_sum
45+
46+
## Exception messages
47+
48+
Sometimes it is necessary to [raise an exception](https://docs.python.org/3/tutorial/errors.html#raising-exceptions). When you do this, you should always include a **meaningful error message** to indicate what the source of the error is. This makes your code more readable and helps significantly with debugging. For situations where you know that the error source will be a certain type, you can choose to raise one of the [built in error types](https://docs.python.org/3/library/exceptions.html#base-classes), but should still include a meaningful message.
49+
50+
This particular exercise requires that you use the [raise statement](https://docs.python.org/3/reference/simple_stmts.html#the-raise-statement) to "throw" a `ValueError` if the `classify()` function is passed a number that is not a _positive integer_. The tests will only pass if you both `raise` the `exception` and include a message with it.
51+
52+
To raise a `ValueError` with a message, write the message as an argument to the `exception` type:
53+
54+
```python
55+
# if a number to be classified is less than 1.
56+
raise ValueError("Classification is only possible for positive integers.")
57+
```
58+
59+
## Source
60+
61+
### Created by
62+
63+
- @behrtam
64+
65+
### Contributed to by
66+
67+
- @cmccandless
68+
- @Dog
69+
- @emerali
70+
- @ikhadykin
71+
- @N-Parsons
72+
- @olufotebig
73+
- @pheanex
74+
- @saurabhchalke
75+
- @smalley
76+
- @tqa236
77+
78+
### Based on
79+
80+
Taken from Chapter 2 of Functional Thinking by Neal Ford. - https://www.oreilly.com/library/view/functional-thinking/9781449365509/

perfect-numbers/perfect_numbers.py

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
"""
2+
Determine if a number is perfect, abundant, or deficient based on
3+
Nicomachus' (60 - 120 CE) classification scheme for positive integers.
4+
"""
5+
6+
import math
7+
8+
9+
def classify(number: int) -> str:
10+
"""
11+
A perfect number equals the sum of its positive divisors.
12+
13+
:param number: int a positive integer
14+
:return: str the classification of the input integer
15+
"""
16+
if number < 1:
17+
raise ValueError(
18+
"Classification is only possible for positive integers."
19+
)
20+
21+
total_divisors: int = 1
22+
23+
for n in range(2, int(math.sqrt(number)) + 1):
24+
if number % n == 0:
25+
total_divisors += n
26+
if n != number // n:
27+
total_divisors += number // n
28+
29+
if number == 1 or number > total_divisors:
30+
return "deficient"
31+
32+
if total_divisors == number:
33+
return "perfect"
34+
35+
return "abundant"
Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
# pylint: disable=C0114, C0115, C0116, R0904
2+
# These tests are auto-generated with test data from:
3+
# https://github.com/exercism/problem-specifications/tree/main/exercises/perfect-numbers/canonical-data.json
4+
# File last updated on 2023-07-19
5+
6+
import unittest
7+
8+
from perfect_numbers import (
9+
classify,
10+
)
11+
12+
13+
class PerfectNumbersTest(unittest.TestCase):
14+
def test_smallest_perfect_number_is_classified_correctly(self):
15+
self.assertEqual(classify(6), "perfect")
16+
17+
def test_medium_perfect_number_is_classified_correctly(self):
18+
self.assertEqual(classify(28), "perfect")
19+
20+
def test_large_perfect_number_is_classified_correctly(self):
21+
self.assertEqual(classify(33550336), "perfect")
22+
23+
24+
class AbundantNumbersTest(unittest.TestCase):
25+
def test_smallest_abundant_number_is_classified_correctly(self):
26+
self.assertEqual(classify(12), "abundant")
27+
28+
def test_medium_abundant_number_is_classified_correctly(self):
29+
self.assertEqual(classify(30), "abundant")
30+
31+
def test_large_abundant_number_is_classified_correctly(self):
32+
self.assertEqual(classify(33550335), "abundant")
33+
34+
35+
class DeficientNumbersTest(unittest.TestCase):
36+
def test_smallest_prime_deficient_number_is_classified_correctly(self):
37+
self.assertEqual(classify(2), "deficient")
38+
39+
def test_smallest_non_prime_deficient_number_is_classified_correctly(self):
40+
self.assertEqual(classify(4), "deficient")
41+
42+
def test_medium_deficient_number_is_classified_correctly(self):
43+
self.assertEqual(classify(32), "deficient")
44+
45+
def test_large_deficient_number_is_classified_correctly(self):
46+
self.assertEqual(classify(33550337), "deficient")
47+
48+
def test_edge_case_no_factors_other_than_itself_is_classified_correctly(self):
49+
self.assertEqual(classify(1), "deficient")
50+
51+
52+
class InvalidInputsTest(unittest.TestCase):
53+
def test_zero_is_rejected_as_it_is_not_a_positive_integer(self):
54+
with self.assertRaises(ValueError) as err:
55+
classify(0)
56+
self.assertEqual(type(err.exception), ValueError)
57+
self.assertEqual(
58+
err.exception.args[0],
59+
"Classification is only possible for positive integers.",
60+
)
61+
62+
def test_negative_integer_is_rejected_as_it_is_not_a_positive_integer(self):
63+
with self.assertRaises(ValueError) as err:
64+
classify(-1)
65+
self.assertEqual(type(err.exception), ValueError)
66+
self.assertEqual(
67+
err.exception.args[0],
68+
"Classification is only possible for positive integers.",
69+
)

0 commit comments

Comments
 (0)