Skip to content

Commit dd12322

Browse files
improved test description messages
1 parent e9a6695 commit dd12322

File tree

1 file changed

+14
-70
lines changed

1 file changed

+14
-70
lines changed

packages/frontend/tests/acceptance/route-performance-test.js

Lines changed: 14 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,7 @@ module('Acceptance | performance', function (hooks) {
4646
let duration = end - start;
4747

4848
assert.strictEqual(currentRouteName(), 'dashboard.week', 'current route name is correct');
49-
assert.ok(
50-
duration < this.maxDuration,
51-
`Render time was ${duration}ms`,
52-
`route loaded in allowable time: ${duration}`,
53-
);
49+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
5450

5551
unfreezeDate();
5652
});
@@ -64,11 +60,7 @@ module('Acceptance | performance', function (hooks) {
6460
let duration = end - start;
6561

6662
assert.strictEqual(currentRouteName(), 'dashboard.materials', 'current route name is correct');
67-
assert.ok(
68-
duration < this.maxDuration,
69-
`Render time was ${duration}ms`,
70-
`route loaded in allowable time: ${duration}`,
71-
);
63+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
7264
});
7365

7466
test('/dashboard/calendar', async function (assert) {
@@ -80,11 +72,7 @@ module('Acceptance | performance', function (hooks) {
8072
let duration = end - start;
8173

8274
assert.strictEqual(currentRouteName(), 'dashboard.calendar', 'current route name is correct');
83-
assert.ok(
84-
duration < this.maxDuration,
85-
`Render time was ${duration}ms`,
86-
`route loaded in allowable time: ${duration}`,
87-
);
75+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
8876
});
8977

9078
test('/weeklyevents', async function (assert) {
@@ -96,11 +84,7 @@ module('Acceptance | performance', function (hooks) {
9684
let duration = end - start;
9785

9886
assert.strictEqual(currentRouteName(), 'weeklyevents', 'current route name is correct');
99-
assert.ok(
100-
duration < this.maxDuration,
101-
`Render time was ${duration}ms`,
102-
`route loaded in allowable time: ${duration}`,
103-
);
87+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
10488
});
10589

10690
test('/courses', async function (assert) {
@@ -123,11 +107,7 @@ module('Acceptance | performance', function (hooks) {
123107
let duration = end - start;
124108

125109
assert.strictEqual(currentRouteName(), 'courses', 'current route name is correct');
126-
assert.ok(
127-
duration < this.maxDuration,
128-
`Render time was ${duration}ms`,
129-
`route loaded in allowable: ${duration}`,
130-
);
110+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
131111
});
132112

133113
test('/courses/[course-id]/sessions', async function (assert) {
@@ -156,11 +136,7 @@ module('Acceptance | performance', function (hooks) {
156136
let duration = end - start;
157137

158138
assert.strictEqual(currentRouteName(), 'course.index', 'current route name is correct');
159-
assert.ok(
160-
duration < this.maxDuration,
161-
`Render time was ${duration}ms`,
162-
`route loaded in allowable: ${duration}`,
163-
);
139+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
164140
});
165141

166142
test('/learnergroups', async function (assert) {
@@ -184,11 +160,7 @@ module('Acceptance | performance', function (hooks) {
184160
let duration = end - start;
185161

186162
assert.strictEqual(currentRouteName(), 'learner-groups', 'current route name is correct');
187-
assert.ok(
188-
duration < this.maxDuration,
189-
`Render time was ${duration}ms`,
190-
`route loaded in allowable time: ${duration}`,
191-
);
163+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
192164
});
193165

194166
test('/instructorgroups', async function (assert) {
@@ -209,11 +181,7 @@ module('Acceptance | performance', function (hooks) {
209181
let duration = end - start;
210182

211183
assert.strictEqual(currentRouteName(), 'instructor-groups', 'current route is correct');
212-
assert.ok(
213-
duration < this.maxDuration,
214-
`Render time was ${duration}ms`,
215-
`route loaded in allowable time: ${duration}`,
216-
);
184+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
217185
});
218186

219187
test('/schools', async function (assert) {
@@ -229,11 +197,7 @@ module('Acceptance | performance', function (hooks) {
229197
let duration = end - start;
230198

231199
assert.strictEqual(currentRouteName(), 'schools', 'current route name is correct');
232-
assert.ok(
233-
duration < this.maxDuration,
234-
`Render time was ${duration}ms`,
235-
`route loaded in allowable time: ${duration}`,
236-
);
200+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
237201
});
238202

239203
test('/programs', async function (assert) {
@@ -249,11 +213,7 @@ module('Acceptance | performance', function (hooks) {
249213
let duration = end - start;
250214

251215
assert.strictEqual(currentRouteName(), 'programs', 'current route name is correct');
252-
assert.ok(
253-
duration < this.maxDuration,
254-
`Render time was ${duration}ms`,
255-
`route loaded in allowable time: ${duration}`,
256-
);
216+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
257217
});
258218

259219
test('/reports', async function (assert) {
@@ -302,11 +262,7 @@ module('Acceptance | performance', function (hooks) {
302262
let duration = end - start;
303263

304264
assert.strictEqual(currentRouteName(), 'reports.subjects', 'current route name is correct');
305-
assert.ok(
306-
duration < this.maxDuration,
307-
`Render time was ${duration}ms`,
308-
`route loaded in allowable time: ${duration}`,
309-
);
265+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
310266
});
311267

312268
test('/admin', async function (assert) {
@@ -318,11 +274,7 @@ module('Acceptance | performance', function (hooks) {
318274
let duration = end - start;
319275

320276
assert.strictEqual(currentRouteName(), 'admin-dashboard', 'current route name is correct');
321-
assert.ok(
322-
duration < this.maxDuration,
323-
`Render time was ${duration}ms`,
324-
`route loaded in allowable time: ${duration}`,
325-
);
277+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
326278
});
327279

328280
test('/users', async function (assert) {
@@ -336,11 +288,7 @@ module('Acceptance | performance', function (hooks) {
336288
let duration = end - start;
337289

338290
assert.strictEqual(currentRouteName(), 'users', 'current route name is correct');
339-
assert.ok(
340-
duration < this.maxDuration,
341-
`Render time was ${duration}ms`,
342-
`route loaded in allowable time: ${duration}`,
343-
);
291+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
344292
});
345293

346294
test('/curriculum-inventory-reports', async function (assert) {
@@ -364,10 +312,6 @@ module('Acceptance | performance', function (hooks) {
364312
'curriculum-inventory-reports',
365313
'current route name is correct',
366314
);
367-
assert.ok(
368-
duration < this.maxDuration,
369-
`Render time was ${duration}ms`,
370-
`route loaded in allowable time: ${duration}`,
371-
);
315+
assert.ok(duration < this.maxDuration, `route loaded in allowable time: ${duration}ms`);
372316
});
373317
});

0 commit comments

Comments
 (0)