-
Notifications
You must be signed in to change notification settings - Fork 27
Add route loading performance acceptance test #8702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route loading performance acceptance test #8702
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
32d1776 to
3599671
Compare
3599671 to
d745403
Compare
d745403 to
dd12322
Compare
|
i don't know what to make of this. does this add value? let's talk, perhaps on Thursday during the standup. i'm adding the "needs discussion" label. |
|
@stopfstedt Fair assessment. I believe this came up a while ago when I was initially checking slow-running reports, and it gave me the idea to add some kind of loading performance test to make sure routes, especially ones that can be expected to take longer than others, load in an acceptable amount of time. For this to be truly useful, I should probably add more "loading" to things like Courses and Reports so they mimic actual sizes of data. |
thanks for elaborating. i think i'm starting to see the light. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Fixes ilios/ilios#6340
This adds a new frontend acceptance test that loads all the major routes and makes sure they pass a minimum duration threshold.