Skip to content

Conversation

@michaelchadwick
Copy link
Contributor

@michaelchadwick michaelchadwick commented Jul 22, 2025

Fixes ilios/ilios#6340

This adds a new frontend acceptance test that loads all the major routes and makes sure they pass a minimum duration threshold.

@netlify
Copy link

netlify bot commented Jul 22, 2025

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 6836c5b
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/68f002c5739f6c00091966e0
😎 Deploy Preview https://deploy-preview-8702--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@michaelchadwick michaelchadwick force-pushed the frontend-6340-add-perf-tests branch from 32d1776 to 3599671 Compare September 11, 2025 15:38
@michaelchadwick michaelchadwick force-pushed the frontend-6340-add-perf-tests branch from 3599671 to d745403 Compare October 14, 2025 23:39
@michaelchadwick michaelchadwick force-pushed the frontend-6340-add-perf-tests branch from d745403 to dd12322 Compare October 15, 2025 18:41
@michaelchadwick michaelchadwick changed the title Add performance acceptance tests Add major route loading performance acceptance test Oct 15, 2025
@michaelchadwick michaelchadwick changed the title Add major route loading performance acceptance test Add route loading performance acceptance test Oct 15, 2025
@michaelchadwick michaelchadwick marked this pull request as ready for review October 15, 2025 21:48
@stopfstedt
Copy link
Member

i don't know what to make of this. does this add value? let's talk, perhaps on Thursday during the standup. i'm adding the "needs discussion" label.

@michaelchadwick
Copy link
Contributor Author

@stopfstedt Fair assessment. I believe this came up a while ago when I was initially checking slow-running reports, and it gave me the idea to add some kind of loading performance test to make sure routes, especially ones that can be expected to take longer than others, load in an acceptable amount of time.

For this to be truly useful, I should probably add more "loading" to things like Courses and Reports so they mimic actual sizes of data.

@stopfstedt
Copy link
Member

For this to be truly useful, I should probably add more "loading" to things like Courses and Reports so they mimic actual sizes of data.

thanks for elaborating. i think i'm starting to see the light.

Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@stopfstedt stopfstedt added the run ui tests Run the expensive UI tests label Oct 22, 2025
@stopfstedt stopfstedt enabled auto-merge October 22, 2025 15:44
@stopfstedt stopfstedt merged commit 0043585 into ilios:master Oct 22, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run ui tests Run the expensive UI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Acceptance test suite should also do some site performance testing

2 participants