Skip to content

Commit a575911

Browse files
authored
Merge pull request #18 from im-open/ITHD-239416-b
Update to node20 +semver:minor
2 parents 3e4d083 + c999dc7 commit a575911

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

.github/workflows/build-and-review-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ jobs:
9595

9696
- name: Setup - Checkout the action
9797
if: always()
98-
uses: actions/checkout@v3
98+
uses: actions/checkout@v4
9999

100100
- name: Setup - Verify the internal repo to clone dir does not exist
101101
if: always()

README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ More details on context, usage, troubleshooting or known issues and limitations
2929
- [Tests](#tests)
3030
- [Code of Conduct](#code-of-conduct)
3131
- [License](#license)
32-
32+
3333
## Inputs
3434

3535
| Parameter | Is Required | Description |
@@ -70,37 +70,37 @@ The `validation-error` output will only contain one validation error at a time.
7070
```yml
7171
name: Map project versions
7272
on: workflow_dispatch
73-
env:
73+
env:
7474
# These ENV variables contain the value of the private key
7575
# They can be set at the workflow, job or step level
7676
SSH_KEY_CENTRAL_LOGGING: ${{secrets.SSH_CENTRAL_LOGGING}}
7777
SSH_KEY_STORAGE_ACCOUNT: ${{secrets.SSH_STORAGE_ACCOUNT}}
78-
SSH_KEY_ON_PREM_EGRESS: ${{secrets.SSH_ON_PREM_EGRESS}}
78+
SSH_KEY_ON_PREM_EGRESS: ${{secrets.SSH_ON_PREM_EGRESS}}
7979

8080
jobs:
8181
deploy-terraform:
8282
runs-on: ubuntu-20.04
8383
steps:
8484
- name: Checkout Repository
85-
uses: actions/checkout@v3
86-
85+
uses: actions/checkout@v4
86+
8787
- name: Setup deploy keys for use with Terraform
8888
# You may also reference just the major or major.minor version
89-
uses: im-open/setup-deploy-keys@v1.1.4
89+
uses: im-open/setup-deploy-keys@v1.2.0
9090
with:
9191
deploy-key-info: |
9292
[
9393
{ "orgAndRepo": "im-platform/central-logging", "envName" : "SSH_KEY_CENTRAL_LOGGING" },
9494
{ "orgAndRepo": "im-platform/storage-account-network-rules", "envName" : "SSH_KEY_STORAGE_ACCOUNT" },
9595
{ "orgAndRepo": "im-platform/on-prem-egress-ips", "envName" : "SSH_KEY_ON_PREM_EGRESS" }
9696
]
97-
97+
9898
- name: Setup Terraform
9999
id: setup
100100
uses: hashicorp/[email protected]
101101
with:
102102
terraform_version: ~>0.15.0
103-
103+
104104
- name: Terraform Init
105105
id: init
106106
run: terraform init
@@ -130,7 +130,7 @@ This repo uses [git-version-lite] in its workflows to examine commit messages to
130130

131131
### Source Code Changes
132132

133-
The files and directories that are considered source code are listed in the `files-with-code` and `dirs-with-code` arguments in both the [build-and-review-pr] and [increment-version-on-merge] workflows.
133+
The files and directories that are considered source code are listed in the `files-with-code` and `dirs-with-code` arguments in both the [build-and-review-pr] and [increment-version-on-merge] workflows.
134134

135135
If a PR contains source code changes, the README.md should be updated with the latest action version and the action should be recompiled. The [build-and-review-pr] workflow will ensure these steps are performed when they are required. The workflow will provide instructions for completing these steps if the PR Author does not initially complete them.
136136

@@ -151,7 +151,7 @@ If changes are made to the action's [source code], the [usage examples] section
151151

152152
### Tests
153153

154-
The [build-and-review-pr] workflow includes tests which are linked to a status check. That status check needs to succeed before a PR is merged to the default branch. When a PR comes from a branch, the workflow has access to secrets which are required to run the tests successfully.
154+
The [build-and-review-pr] workflow includes tests which are linked to a status check. That status check needs to succeed before a PR is merged to the default branch. When a PR comes from a branch, the workflow has access to secrets which are required to run the tests successfully.
155155

156156
When a PR comes from a fork, the workflow cannot access any secrets, so the tests won't have the necessary permissions to run. When a PR comes from a fork, the changes should be reviewed, then merged into an intermediate branch by repository owners so tests can be run against the PR changes. Once the tests have passed, changes can be merged into the default branch.
157157

action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ outputs:
1414
description: 'A string with a short description of a validation error that occurred. Generally used for testing but can be used programmatically to detect which types of validation errors the action is encountering.'
1515
key-filename:
1616
description: 'The name of the file where the key was written to disk. Generally used for testing because the output would only reflect the last key that was processed.'
17-
17+
1818
runs:
19-
using: 'node16'
19+
using: 'node20'
2020
main: 'dist/index.js'
2121
post: 'dist/cleanup.js'
2222
post-if: 'always()'

0 commit comments

Comments
 (0)