When - Automatically clean up files left behind by interrupted uploads?

[chriswa81]

I have a question about the new function “Automatic deletion of failed upload files”. When is this data deleted? I have tested it and interrupted various uploads. The data remains in the upload folder.
I used to be able to delete them manually. This is canceled with an error message when trying to delete manually. Before the update, I was able to delete files manually from the upload folder.

[bo0tzz]

The way it works is that when an upload fails, the data that was being uploaded should get deleted. Other files that were already there from before this update aren't affected, you'll still need to clean those up manually.

[chriswa81]

Then the automatic cleanup does not work for me. Current upload aborts are not deleted.

[bo0tzz]

Are you on v1.122.1?

[chriswa81]

Yes.

[Acidiphilium]

Is there a way to find the corrupted uploaded files which were uploaded in the past by an interrupted uploads? How do we clean this upload folders? I remember in a previous immich version, it had a function to list all failed uploads but you removed that option so now how do we know what could be those failed videos in that upload folder?

Thanks for the great work again. I love immich really :-)

[alextran1502]

You can turn on Storage Template feature, then run Storage Migration Job, after that, the left over files in upload folder are the partial files

[Acidiphilium]

Thanks for the tips! May I ask you: can I then revert back from that operation without any trouble?

[chriswa81]

Was it possible to reproduce the issue or should I officially document it again here under "Issues"?

[alextran1502]

The data is deleted as soon as the upload is canceled. You can go to the Adminstration settings > Server Settings > set logs to verbose to see the actual file path that get removed

Ah wait, I only have that logged during development. How did you identify the partial files are not removed?

[chriswa81]

The failed upload data is still in the immich upload folder. It is definitely this data and can be reproduced.

[alextran1502]

Please note that this mechanism only applied for new upload, not removing existing failed upload files from previous version

[chriswa81]

I know. I am aware of that. That's why I can reproduce it with current upload tests with the current version 1.122.1.

[alextran1502]

Can you walk me through how do you identify the file isn't get deleted?

[chriswa81]

Here is my explanation of how I can determine that the incorrect uploads are not deleted:

My Upload-Location is:

The interrupted uploads are then stored here:

This folder contains the interrupted data that is not deleted by immich.

[bo0tzz]

The folder itself is expected to stay around. What does it actually contain? If you reproduce the issue, do you see a new file appear in there and stay around?

[chriswa81]

Correct uploads are uploaded or saved according to the storage template. Only canceled or incorrectly uploaded media remain in the upload folder.
If I reproduce it, a new folder is created (e.g. folder with name 6e) and a file with the size until the upload was canceled is stored in it.
These folders or data are not deleted, as it should happen according to the function of version 1.122.0.

[alextran1502]

For clarification, the file will be deleted, not the folder containing the file

[chriswa81]

And that is precisely not the case. The partial data is still available in the respective folders.

[alextran1502]

Let me try to double check to see if I can reproduce this