Skip to content

ParallelDownload does not close output file after download completed and merged? #416

Open
@ZHOUYue67

Description

@ZHOUYue67

The *os.File returned by getOutputFile() never seems to get closed in mergeFile(). Is this a bug, or I'm using this the wrong way?

(Windows平台)用了ParallelDownload后立马os.Rename()文件会失败,提示文件正在被使用,我把parallel_download.go单独拿出来改,在mergeFile()里加上等同于defer file.Close()的代码,就可以正确使用了。
虽然os/file_windows.gonewFile()里,存在runtime.SetFinalizer(f.file, (*file).close),但还是建议可控环境下主动调用os.File.Close()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions