Skip to content

Rework OrderControllerTest class #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbj4074 opened this issue Aug 13, 2020 · 2 comments
Open

Rework OrderControllerTest class #185

cbj4074 opened this issue Aug 13, 2020 · 2 comments
Assignees

Comments

@cbj4074
Copy link
Member

cbj4074 commented Aug 13, 2020

This class's setUp() method calls $this->markTestSkipped('The Order implementation is being reworked');, added as a temporary holdover during the Velkart package integration process.

This call needs to removed, and the relevant tests updated/reworked, as appropriate.

@cbj4074 cbj4074 added the todo label Oct 6, 2020
@cbj4074
Copy link
Member Author

cbj4074 commented Oct 12, 2020

After further scrutiny, my instinct is that all of this functionality (and accompanying tests) should be moved into the Velkart package. I'll post another update soon, once I've worked through it. (I'm currently adding a Velkart section to the documentation, which will elucidate the details.)

@mblarsen
Copy link
Contributor

Sounds reasonable 👍

@cbj4074 cbj4074 self-assigned this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants