Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant checks for not-supplied offset parameters in invoker #929

Open
1 task
inducer opened this issue Mar 28, 2025 · 0 comments
Open
1 task

Redundant checks for not-supplied offset parameters in invoker #929

inducer opened this issue Mar 28, 2025 · 0 comments

Comments

@inducer
Copy link
Owner

inducer commented Mar 28, 2025

Visible in https://gist.github.com/matthiasdiener/b50910994b638097c37c9162f2005982, as flagged in illinois-ceesd/mirgecom#1101. Interspersed between enqueues.

Seems like this is mostly about offset parameters.

Also:

  • Incorrect error messages in those.

Example:

    if _actx_in_1_6_ox_mass_0_offset is None:
        raise RuntimeError("input argument '{var_descr.name}' must be supplied")
    if _pt_data_141_offset is None:
        raise RuntimeError("input argument '{var_descr.name}' must be supplied")
    if dof_pick_list_indices_10_offset is None:
        raise RuntimeError("input argument '{var_descr.name}' must be supplied")
    if dof_pick_list_indices_11_offset is None:
        raise RuntimeError("input argument '{var_descr.name}' must be supplied")
    if dof_pick_lists_10_offset is None:
        raise RuntimeError("input argument '{var_descr.name}' must be supplied")
    if dof_pick_lists_11_offset is None:
        raise RuntimeError("input argument '{var_descr.name}' must be supplied")
    if from_el_indices_16_offset is None:
        raise RuntimeError("input argument '{var_descr.name}' must be supplied")

cc @matthiasdiener

@inducer inducer changed the title Redundant checks for not-supplied parameters Redundant checks for not-supplied parameters in invoker Mar 28, 2025
@inducer inducer changed the title Redundant checks for not-supplied parameters in invoker Redundant checks for not-supplied offset parameters in invoker Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant