Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOF axis tags should include (at least) element group type, order #453

Open
inducer opened this issue Mar 7, 2025 · 1 comment
Open

Comments

@inducer
Copy link
Owner

inducer commented Mar 7, 2025

Right now, fusion in the CEESD branches is only based on loop length, but this can be insufficient. In the tensor product setting, the number of quadrature DOFs and interpolatory DOFs can be the same, but vectors from those two element groups should never be involved in the same expression, hence there won't ever be horizontal fusion.

At the same time, the current fusion algorithm is quite eager to discard fusion candidates, which can wreck fusion if a non-fusible pair of inames is found.

Thus IMO it makes sense to distinguish axes more finely.

cc @majosm

@kaushikcfd
Copy link
Collaborator

Right now, fusion in the CEESD branches is only based on loop length, but this can be insufficient

Slight correction: It's tag-type + loop-length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants