also check cse.get_extra_properties

Author: alexfikl

pymbolic/mapper/equality.py

@@ -213,7 +213,11 @@ def map_common_subexpression(self, expr, other) -> bool:
         return (
                 expr.prefix == other.prefix
                 and expr.scope == other.scope
-                and self.rec(expr.child, other.child))
+                and self.rec(expr.child, other.child)
+                and all(k == other_k and v == other_v
+                    for (k, v), (other_k, other_v) in zip(
+                        expr.get_extra_properties(),
+                        other.get_extra_properties())))
 
     def map_substitution(self, expr, other) -> bool:
         return (

pymbolic/primitives.py

@@ -996,12 +996,6 @@ class Quotient(QuotientBase):
     .. attribute:: denominator
     """
 
-    def is_equal(self, other):
-        from pymbolic.rational import Rational
-        return isinstance(other, (Rational, Quotient)) \
-               and (self.numerator == other.numerator) \
-               and (self.denominator == other.denominator)
-
     mapper_method = intern("map_quotient")