-
Notifications
You must be signed in to change notification settings - Fork 29
Description
When running the install script from inside of a terminal in pinokio on windows that already has a venv setup it breaks out, goes to the users windows home directory, and creates a venv there instead of installing where it's supposed to which in this case was /c/pinokio/api/LMStudio-MCP.
The activate script contains the following so should be easy enough to detect if it's necessary to setup a venv
VIRTUAL_ENV="C:\pinokio\api\LMStudio-MCP"
install.sh seems to expect the activate script to be installed in bin, but this this can vary... On this system the activate script is in Scripts/ but I've seen that vary a little over the years depending on which virtual environment tool is installed and HOW it was install... what's installed by pip isn't always the same as what's installed by the package manager. there are at least a half dozen venv utils around.... venv, pyvenv. pyenv, virtualenv, virtualenvwrapper, pipenv.... and then there are the wrappers that use them and try and make life easier but never really do.
I ended up commenting out all the venv stuff in the script and fixing the path from $HOME to pwd and it installed fine.
install.sh should check to see if it's already in a venv and if it's venv or maybe just check the subdirectories for an activate script.