Problem
The doc comment on latestPendingExternal (src/lib/membership/phases.ts:59-64) says:
"Kind-agnostic by design — INITIAL applications AND renewals both re-sign here"
But src/lib/membership/renewal.ts explicitly never re-signs ("The Zoho contract is NOT re-signed at renewal") and renewal processes never enter PENDING_EXTERNAL_ACTION (PENDING_RENEWAL → RENEWAL_PENDING_BG | PENDING_PAYMENT).
Behavior is unaffected — the status filter simply never matches a renewal — but the stated rationale for being kind-agnostic is wrong and could mislead a future change (e.g. someone "fixing" the sign button to show for renewals).
Docs-only fix: correct the comment (kind-agnostic is fine because the status alone is sufficient).
Problem
The doc comment on
latestPendingExternal(src/lib/membership/phases.ts:59-64) says:But
src/lib/membership/renewal.tsexplicitly never re-signs ("The Zoho contract is NOT re-signed at renewal") and renewal processes never enterPENDING_EXTERNAL_ACTION(PENDING_RENEWAL→RENEWAL_PENDING_BG|PENDING_PAYMENT).Behavior is unaffected — the status filter simply never matches a renewal — but the stated rationale for being kind-agnostic is wrong and could mislead a future change (e.g. someone "fixing" the sign button to show for renewals).
Docs-only fix: correct the comment (kind-agnostic is fine because the status alone is sufficient).