-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation involves no less than 6 instructlab-* packages #2010
Comments
This seems like something that should be in https://github.com/instructlab/instructlab not taxonomy. |
|
@jpodivin not necessarily to disagree, but to add context.
I suspect there may be other, (better?) reasons for the split, but I don't know for sure. |
This issue has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. |
This issue has been automatically closed due to inactivity. Please feel free to reopen if you feel it is still relevant! |
Installing instruct lab is split across several packages, all of which need to be installed in order to obtain functioning environment. This is besides other, 3rd party dependencies, and indirect dependencies of packages concerned.
This creates two issues.
First and foremost, maintaining releases of six packages is inherently more complicated than maintaining 2. We could combine them all for distribution, but this would be prone to issues, not mention confusing to users of instruct lab as the pip packages wouldn't correspond to packages rpm packages.
Second, changes to code in dependent instructlab-* packages will require dependency declarations as part of the PR, covering the path in dependency graph. This approach has to be also implemented in CI, making sure that changes across the chain is tested in turn.
At the same time the APIs must be maintained rigorously, so that no incompatibilities between libraries arise.
Imho, it would be easier to combine at least some of the packages into general utilities/lib package.
The text was updated successfully, but these errors were encountered: