Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate chunk_word_count once we move to HybridChunker #508

Open
bbrowning opened this issue Jan 27, 2025 · 1 comment
Open

Deprecate chunk_word_count once we move to HybridChunker #508

bbrowning opened this issue Jan 27, 2025 · 1 comment
Milestone

Comments

@bbrowning
Copy link
Contributor

The chunk_word_count parameter (wired all the way through from the ilab CLI) can be deprecated, as we'll no longer be approximating chunks with a word count once we move to the HybridChunker.

We may need some other way to specify chunk size, like a token count, but this issue is just about deprecating chunk_word_count.

@bbrowning bbrowning added this to the 0.8.0 milestone Jan 27, 2025
@bbrowning
Copy link
Contributor Author

This will likely require corresponding work in the instructlab/instructlab repo to deprecate this within the config and CLI over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant