From abd569cf04d4c80dc31b30c65456de99b74724e2 Mon Sep 17 00:00:00 2001 From: Itsuki Toyota Date: Thu, 28 Feb 2019 22:35:25 +0900 Subject: [PATCH 1/2] Delete superfluous optimizer suggestion This example doesn't have an em optimizer so the error message shouldn't suggest to use it. --- .../scala/org/apache/spark/mllib/topicModeling/LDAExample.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/scala/org/apache/spark/mllib/topicModeling/LDAExample.scala b/src/main/scala/org/apache/spark/mllib/topicModeling/LDAExample.scala index b71d4fe..48d26bb 100644 --- a/src/main/scala/org/apache/spark/mllib/topicModeling/LDAExample.scala +++ b/src/main/scala/org/apache/spark/mllib/topicModeling/LDAExample.scala @@ -183,7 +183,7 @@ object LDAExample { optimizer.setAlphaAS(params.gibbsAlphaAS.toFloat) optimizer case _ => - throw new IllegalArgumentException(s"available optimizers are em, online and gibbs, but got ${params.optimizer}") + throw new IllegalArgumentException(s"available optimizers are online and gibbs, but got ${params.optimizer}") } } From c4111329f37e20a8f55dc31975cf7d8169d999ea Mon Sep 17 00:00:00 2001 From: Itsuki Toyota Date: Fri, 1 Mar 2019 21:39:29 +0900 Subject: [PATCH 2/2] Use gibbs instead of em as default optimizer --- .../scala/org/apache/spark/mllib/topicModeling/LDAExample.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/scala/org/apache/spark/mllib/topicModeling/LDAExample.scala b/src/main/scala/org/apache/spark/mllib/topicModeling/LDAExample.scala index 48d26bb..f8dcd29 100644 --- a/src/main/scala/org/apache/spark/mllib/topicModeling/LDAExample.scala +++ b/src/main/scala/org/apache/spark/mllib/topicModeling/LDAExample.scala @@ -81,7 +81,7 @@ object LDAExample { stopwordFile: String = "", checkpointDir: Option[String] = None, checkpointInterval: Int = 10, - optimizer:String = "em", + optimizer:String = "gibbs", gibbsSampler:String = "alias", gibbsAlphaAS:Double = 0.1, gibbsPrintPerplexity:Boolean = false,