Skip to content

Commit 8c39641

Browse files
committed
libtdx-attest: minor improvements of the test_tdx_attest utility program
- Remove useless variable - Print error code for various functions
1 parent 6882afa commit 8c39641

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

QuoteGeneration/quote_wrapper/tdx_attest/test_tdx_attest.c

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@
3535
#include <time.h>
3636
#include "tdx_attest.h"
3737

38-
#define devname "/dev/tdx-attest"
39-
4038
#define HEX_DUMP_SIZE 16
4139

4240
static void print_hex_dump(const char *title, const char *prefix_str,
@@ -81,19 +79,22 @@ int main(int argc, char *argv[])
8179
uint8_t *p_quote_buf = NULL;
8280
tdx_rtmr_event_t rtmr_event = {0};
8381
FILE *fptr = NULL;
82+
uint32_t ret = 0;
8483

8584
gen_report_data(report_data.d);
8685
print_hex_dump("\n\t\tTDX report data\n", " ", report_data.d, sizeof(report_data.d));
8786

88-
if (TDX_ATTEST_SUCCESS != tdx_att_get_report(&report_data, &tdx_report)) {
89-
fprintf(stderr, "\nFailed to get the report\n");
87+
ret = tdx_att_get_report(&report_data, &tdx_report);
88+
if (TDX_ATTEST_SUCCESS != ret) {
89+
fprintf(stderr, "\nFailed to get the report (%d)\n", ret);
9090
return 1;
9191
}
9292
print_hex_dump("\n\t\tTDX report\n", " ", tdx_report.d, sizeof(tdx_report.d));
9393

94-
if (TDX_ATTEST_SUCCESS != tdx_att_get_quote(&report_data, NULL, 0, &selected_att_key_id,
95-
&p_quote_buf, &quote_size, 0)) {
96-
fprintf(stderr, "\nFailed to get the quote\n");
94+
ret = tdx_att_get_quote(&report_data, NULL, 0, &selected_att_key_id,
95+
&p_quote_buf, &quote_size, 0);
96+
if (TDX_ATTEST_SUCCESS != ret) {
97+
fprintf(stderr, "\nFailed to get the quote (%d)\n", ret);
9798
return 1;
9899
}
99100
print_hex_dump("\n\t\tTDX quote data\n", " ", p_quote_buf, quote_size);
@@ -114,16 +115,18 @@ int main(int argc, char *argv[])
114115
}
115116
rtmr_event.event_data_size = 0;
116117

117-
if (TDX_ATTEST_SUCCESS != tdx_att_extend(&rtmr_event)) {
118-
fprintf(stderr, "\nFailed to extend rtmr[2]\n");
118+
ret = tdx_att_extend(&rtmr_event);
119+
if (TDX_ATTEST_SUCCESS != ret) {
120+
fprintf(stderr, "\nFailed to extend rtmr[2] (%d)\n", ret);
119121
} else {
120122
fprintf(stderr, "\nSuccessfully extended rtmr[2]\n");
121123
}
122124

123125
rtmr_event.rtmr_index = 3;
124126

125-
if (TDX_ATTEST_SUCCESS != tdx_att_extend(&rtmr_event)) {
126-
fprintf(stderr, "\nFailed to extend rtmr[3]\n");
127+
ret = tdx_att_extend(&rtmr_event);
128+
if (TDX_ATTEST_SUCCESS != ) {
129+
fprintf(stderr, "\nFailed to extend rtmr[3] (%d)\n", ret);
127130
} else {
128131
fprintf(stderr, "\nSuccessfully extended rtmr[3]\n");
129132
}

0 commit comments

Comments
 (0)