test: add test for mismatch package build #4785
Open
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prtm2110
reviewed
Feb 10, 2025
test/test_mismatch_cli.py
Outdated
| @pytest.mark.skipif(not LONG_TESTS(), reason="Skipping long tests") | ||
| def test_package_build(build_cleanup): | ||
| print("Building package") | ||
| build = subprocess.run(["python", "-m", "build"], check=True) |
There was a problem hiding this comment.
Hello, To ensure the code runs on all systems, consider using the path to the Python executable, which can be accessed via sys.executable and import sys. Other than this it looks good!
Suggested change
| build = subprocess.run(["python", "-m", "build"], check=True) | |
| build = subprocess.run([sys.executable, "-m", "build"], check=True) |
There was a problem hiding this comment.
didn't know about this. thanks.
Prtm2110
reviewed
Feb 10, 2025
test/test_mismatch_cli.py
Outdated
| build = subprocess.run(["python", "-m", "build"], check=True) | ||
| assert build.returncode == 0, "Python build failed" | ||
|
|
||
| print("Install package") |
There was a problem hiding this comment.
Suggested change
| print("Install package") |
We should not have any print statements in a test file
replace 'python' with 'sys.executable' in test_package_build() test
|
Thank you writing tests for #4669 (referencing it here as well). just one more thing from my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4681
Changes:
test/test_mismatch_cli.pyto add a test to check whether themismatchpackage will be properly build and run or not.builddependency indev-requirements.txtwhich is required for building the package for testing.