Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update long and network tests to use python 3.13 #4775

Open
terriko opened this issue Feb 6, 2025 · 2 comments · May be fixed by #4779
Open

ci: update long and network tests to use python 3.13 #4775

terriko opened this issue Feb 6, 2025 · 2 comments · May be fixed by #4779
Labels
good first issue Good for newcomers

Comments

@terriko
Copy link
Contributor

terriko commented Feb 6, 2025

Our long tests and network "may fail" tests currently use python 3.10. I'd like to have those all upgraded to use python 3.13 going forwards.

The big reason is that we've been experiencing an out of memory issue #4710 that we believe to be related to the size of data now in OSV. One of the workarounds includes using python 3.13 (which has other memory improvements), so switching all of those jobs to python 3.13 should help us avoid failures as the OSV data size continues to balloon. There's probably some other benefits around performance and future-proofing but not having CI blocks as GSoC folk get going is my biggest motivation, because if CI gets blocked I'm often the only one who can fix things and it can take a while.

This should be just a couple line change in .github/workflows/testing.yml so I'm marking this as a good first issue for someone.

Short tips for new contributors:

  • cve-bin-tool's contributor docs
  • If you've contributed to open source but not this project, you might just want our checklist for a great pull request
  • cve-bin-tool uses https://www.conventionalcommits.org/ style for commit messages, and we have a test that checks the title of your pull request (PR). A good potential title for this one is in the title of this issue.
  • You can make an issue auto close by including a comment "fixes #ISSUENUMBER" in your PR comments where ISSUENUMBER is the actual number of the issue. This "links" the issue to the pull request.

Claiming issues:

  • You do not need to have an issue assigned to you before you work on it. To "claim" an issue either make a linked pull request or comment on the issue saying you'll be working on it.
  • If someone else has already commented or opened a pull request, assume it is claimed and find another issue to work on.
  • If it's been more than 1 week without progress, you can ask in a comment if the claimant is still working on it before claiming it yourself (give them at least 3 days to respond before assuming they have moved on).
@terriko terriko added the good first issue Good for newcomers label Feb 6, 2025
@Gyan-max
Copy link

Gyan-max commented Feb 7, 2025

Hi @terriko
is this issue still open?

@terriko
Copy link
Contributor Author

terriko commented Feb 7, 2025

@Gyan-max it's got a PR already #4779 so it's "open" in that I haven't merged that yet, but does not need any additional work at this time because there's already a solution in play.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants