Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAISE-BP] Addressed dimensions coming from non-folded arithmetic operations in dimHasModulo #1482

Closed
victor-eds opened this issue Jun 25, 2024 · 5 comments · Fixed by #1570
Closed

[RAISE-BP] Addressed dimensions coming from non-folded arithmetic operations in dimHasModulo #1482

victor-eds opened this issue Jun 25, 2024 · 5 comments · Fixed by #1570
Assignees
@mfrancepillois
Labels
enhancement New feature or request performance
Milestone
0.3 [Triton] Lang...

Comments

@victor-eds
Copy link
Contributor

victor-eds commented Jun 25, 2024 •
edited
Loading

#1481 introduced dimHasModulo, which may not work if the defining operation is not arith.constant. Try to address this issue.

Note our current implementation may generate:

%c0 = arith.constant 0 : i64
%c1 = arith.constant 1 : i64
%0 = arith.muli %c0, %c1 : i64
@victor-eds victor-eds added enhancement New feature or request performance labels Jun 25, 2024
@victor-eds victor-eds self-assigned this Jun 25, 2024
This was referenced Jun 25, 2024
Merged
Closed
mfrancepillois added a commit that referenced this issue Jul 5, 2024
@mfrancepillois
[RAISE-BP] Add support for arith.remsi|remui as tt.addptr input
5f8193e 
- Add minimal support for handling `arith.remsi|remui` as `tt.addptr` input.
- Improve handling of unfolded arithmetic operations when evaluating the modulo property and constant values.

Closes Issue: #1430 and #1482

Signed-off-by: Maxime France-Pillois <[email protected]>
@mfrancepillois mfrancepillois mentioned this issue Jul 5, 2024
Merged
@mfrancepillois mfrancepillois linked a pull request Jul 5, 2024 that will close this issue
[RAISE-BP] Add support for arith.remsi|remui as tt.addptr input #1570
Merged
@mfrancepillois
Copy link
Contributor

PR in review.

1 similar comment
@mfrancepillois
Copy link
Contributor

PR in review.

@mfrancepillois
Copy link
Contributor

Work in progress. We need to find a safe solution for handling modulos.

1 similar comment
@mfrancepillois
Copy link
Contributor

Work in progress. We need to find a safe solution for handling modulos.

@mfrancepillois
Copy link
Contributor

Issue #1784 has been created to address the modulo handling issue.
The PR associated to this issue is just waiting for approval.

whitneywhtsang pushed a commit that referenced this issue Aug 7, 2024
@mfrancepillois
[RAISE-BP] Add support for arith.remsi|remui as tt.addptr input (#…
57a10af 
…1570)

- Add minimal support for handling `arith.remsi|remui` as `tt.addptr`
input.
- Improve handling of unfolded arithmetic operations when evaluating the
modulo property and constant values.

Closes Issue: #1436 and #1482

---------

Signed-off-by: Maxime France-Pillois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfrancepillois mfrancepillois

Labels
enhancement New feature or request performance
Projects
None yet
Milestone
0.3 [Triton] Language and Runtime
Development

Successfully merging a pull request may close this issue.

[RAISE-BP] Add support for arith.remsi|remui as tt.addptr input intel/intel-xpu-backend-for-triton
3 participants
@victor-eds @vlad-penkin @mfrancepillois