Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAISE-BP] Handle mask for load/store ops #1643

Closed
mfrancepillois opened this issue Jul 17, 2024 · 1 comment
Closed

[RAISE-BP] Handle mask for load/store ops #1643

mfrancepillois opened this issue Jul 17, 2024 · 1 comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request performance research

Comments

@mfrancepillois
Copy link
Contributor

If initial load/store ops had non-null masks, these masks must be taken into account when rewriting these operations after the data type has been raised to block pointer.
It appears that masks are not supported for load/store ops using block pointers (i.e. using a mask with a block pointer results in a type mismatch error between the pointer and the mask (which should be a tensor)).
The pass therefore needs to be improved to somehow translate the information provided by the masks into the written load/store operations.

@victor-eds
Copy link
Contributor

This is captured by #1784.

@vlad-penkin vlad-penkin added the duplicate This issue or pull request already exists label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request performance research
Projects
None yet
Development

No branches or pull requests

3 participants