Update readme #2245
Merged
Update readme #2245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbchekin
requested review from
aregm,
anmyachev,
whitneywhtsang,
etiotto and
vlad-penkin
anmyachev
reviewed
Sep 13, 2024
README.md
Outdated
Comment on lines
53
to
58
| ## Prerequisites | ||
|
|
||
| 1. Latest [Rolling Release of GPU driver](https://dgpu-docs.intel.com/driver/installation.html) | ||
| 2. Latest release of [PyTorch Prerequisites for Intel GPUs](https://www.intel.com/content/www/us/en/developer/articles/tool/pytorch-prerequisites-for-intel-gpus.html) | ||
| 3. Latest release of [Profiling Tools Interfaces for Intel GPU (PTI for GPU)](https://www.intel.com/content/www/us/en/developer/articles/tool/pytorch-prerequisites-for-intel-gpus.html) |
There was a problem hiding this comment.
The prerequisites are the same, can there only be one copy of them?
There was a problem hiding this comment.
Yes, they are the same now. I think it is simpler to have them in both sections (Quick install and Install from source) without jumping to the prerequisites in other place. Also note that while currently build and runtime prerequisites are the same in nearest future they can be different.
anmyachev
reviewed
Sep 13, 2024
README.md
Outdated
| Install build tools: | ||
|
|
||
| ```shell | ||
| pip install ninja cmake wheel pybind11 |
There was a problem hiding this comment.
This is not necessary unless we use --no-build-isolation.
vlad-penkin
requested changes
Sep 13, 2024
pbchekin
force-pushed
the
update-readme
branch
from
1cbca82 to
a9e6f48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1814, #1815.