Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wall timing fallback from python/triton/testing.py #2958

Open
anmyachev opened this issue Dec 6, 2024 · 2 comments
Open

Remove wall timing fallback from python/triton/testing.py #2958

anmyachev opened this issue Dec 6, 2024 · 2 comments
Labels
enhancement New feature or request tests: ut upstream: pytorch
Milestone
0.1.1 [Triton / P...

Comments

@anmyachev
Copy link
Contributor

Once we switch to the version of the elapsed_time in PyTorch, this is no longer necessary.

Part of #2030
@anmyachev anmyachev added the enhancement New feature or request label Dec 6, 2024
@alexbaden
Copy link
Contributor

I think we should keep it for awhile to support legacy versions of PyTorch (e.g. 2.5 which probably will not support DLE). Certainly until 2.6 is released in January.

@anmyachev
Copy link
Contributor Author

I think we should keep it for awhile to support legacy versions of PyTorch (e.g. 2.5 which probably will not support DLE). Certainly until 2.6 is released in January.

Good point, but are we testing with PyTorch 2.5 somewhere?

@whitneywhtsang whitneywhtsang mentioned this issue Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tests: ut upstream: pytorch
Projects
None yet
Milestone
0.1.1 [Triton / Pytorch] Switch to Py...
Development

No branches or pull requests
3 participants
@alexbaden @anmyachev @vlad-penkin