Skip to content

Commit 39f9a62

Browse files
committed
More explicit 'CPU count' separator usage
1 parent db861ba commit 39f9a62

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

devops/scripts/benchmarks/benches/compute.py

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -370,9 +370,9 @@ def benchmark_bin(self) -> Path:
370370
"""Returns the path to the benchmark binary"""
371371
return self.bench.project.build_dir / "bin" / self.bench_name
372372

373-
def cpu_count_str(self, separator: str = " ") -> str:
373+
def cpu_count_str(self, separator: str = "") -> str:
374374
return (
375-
f"{separator}CPU count"
375+
f"{separator} CPU count"
376376
if self.profiler_type == PROFILERS.CPU_COUNTER
377377
else ""
378378
)
@@ -592,7 +592,7 @@ def display_name(self) -> str:
592592
if self.KernelExecTime != 1:
593593
info.append(f"KernelExecTime={self.KernelExecTime}")
594594
additional_info = f" {' '.join(info)}" if info else ""
595-
return f"{self.runtime.value.upper()} SubmitKernel {order}{additional_info}, NumKernels {self.NumKernels}{self.cpu_count_str(', ')}"
595+
return f"{self.runtime.value.upper()} SubmitKernel {order}{additional_info}, NumKernels {self.NumKernels}{self.cpu_count_str(separator=',')}"
596596

597597
def explicit_group(self):
598598
order = "in order" if self.ioq else "out of order"
@@ -601,7 +601,7 @@ def explicit_group(self):
601601

602602
kernel_exec_time_str = f" long kernel" if self.KernelExecTime != 1 else ""
603603

604-
return f"SubmitKernel {order}{completion_str}{events_str}{kernel_exec_time_str}{self.cpu_count_str(', ')}"
604+
return f"SubmitKernel {order}{completion_str}{events_str}{kernel_exec_time_str}{self.cpu_count_str(separator=',')}"
605605

606606
def description(self) -> str:
607607
order = "in-order" if self.ioq else "out-of-order"
@@ -677,7 +677,7 @@ def name(self):
677677

678678
def display_name(self) -> str:
679679
order = "in order" if self.ioq else "out of order"
680-
return f"SYCL ExecImmediateCopyQueue {order} from {self.source} to {self.destination}, size {self.size}{self.cpu_count_str(', ')}"
680+
return f"SYCL ExecImmediateCopyQueue {order} from {self.source} to {self.destination}, size {self.size}{self.cpu_count_str(separator=',')}"
681681

682682
def description(self) -> str:
683683
order = "in-order" if self.ioq else "out-of-order"
@@ -730,7 +730,7 @@ def name(self):
730730
return f"memory_benchmark_sycl QueueInOrderMemcpy from {self.source} to {self.destination}, size {self.size}{self.cpu_count_str()}"
731731

732732
def display_name(self) -> str:
733-
return f"SYCL QueueInOrderMemcpy from {self.source} to {self.destination}, size {self.size}{self.cpu_count_str(', ')}"
733+
return f"SYCL QueueInOrderMemcpy from {self.source} to {self.destination}, size {self.size}{self.cpu_count_str(separator=',')}"
734734

735735
def description(self) -> str:
736736
operation = "copy-only" if self.isCopyOnly else "copy and command submission"
@@ -777,7 +777,7 @@ def name(self):
777777
return f"memory_benchmark_sycl QueueMemcpy from {self.source} to {self.destination}, size {self.size}{self.cpu_count_str()}"
778778

779779
def display_name(self) -> str:
780-
return f"SYCL QueueMemcpy from {self.source} to {self.destination}, size {self.size}{self.cpu_count_str(', ')}"
780+
return f"SYCL QueueMemcpy from {self.source} to {self.destination}, size {self.size}{self.cpu_count_str(separator=',')}"
781781

782782
def description(self) -> str:
783783
return (
@@ -1072,7 +1072,7 @@ def enabled(self) -> bool:
10721072
return super().enabled()
10731073

10741074
def explicit_group(self):
1075-
return f"SubmitGraph {self.ioq_str}{self.measure_str}{self.use_events_str}{self.host_tasks_str}, {self.numKernels} kernels{self.cpu_count_str(', ')}"
1075+
return f"SubmitGraph {self.ioq_str}{self.measure_str}{self.use_events_str}{self.host_tasks_str}, {self.numKernels} kernels{self.cpu_count_str(separator=',')}"
10761076

10771077
def description(self) -> str:
10781078
return (
@@ -1084,7 +1084,7 @@ def name(self):
10841084
return f"graph_api_benchmark_{self.runtime.value} SubmitGraph{self.use_events_str}{self.host_tasks_str} numKernels:{self.numKernels} ioq {self.inOrderQueue} measureCompletion {self.measureCompletionTime}{self.cpu_count_str()}"
10851085

10861086
def display_name(self) -> str:
1087-
return f"{self.runtime.value.upper()} SubmitGraph {self.ioq_str}{self.measure_str}{self.use_events_str}{self.host_tasks_str}, {self.numKernels} kernels{self.cpu_count_str(', ')}"
1087+
return f"{self.runtime.value.upper()} SubmitGraph {self.ioq_str}{self.measure_str}{self.use_events_str}{self.host_tasks_str}, {self.numKernels} kernels{self.cpu_count_str(separator=',')}"
10881088

10891089
def get_tags(self):
10901090
return [
@@ -1156,9 +1156,7 @@ def enabled(self) -> bool:
11561156
return super().enabled()
11571157

11581158
def explicit_group(self):
1159-
return (
1160-
f"EmptyKernel, wgc: {self.wgc}, wgs: {self.wgs}{self.cpu_count_str(', ')}"
1161-
)
1159+
return f"EmptyKernel, wgc: {self.wgc}, wgs: {self.wgs}{self.cpu_count_str(separator=',')}"
11621160

11631161
def description(self) -> str:
11641162
return ""
@@ -1167,7 +1165,7 @@ def name(self):
11671165
return f"ulls_benchmark_{self.runtime.value} EmptyKernel wgc:{self.wgc}, wgs:{self.wgs}{self.cpu_count_str()}"
11681166

11691167
def display_name(self) -> str:
1170-
return f"{self.runtime.value.upper()} EmptyKernel, wgc {self.wgc}, wgs {self.wgs}{self.cpu_count_str(', ')}"
1168+
return f"{self.runtime.value.upper()} EmptyKernel, wgc {self.wgc}, wgs {self.wgs}{self.cpu_count_str(separator=',')}"
11711169

11721170
def get_tags(self):
11731171
return [runtime_to_tag_name(self.runtime), "micro", "latency", "submit"]

0 commit comments

Comments
 (0)