Skip to content

Missing feature macro for the bfloat16 extension #18638

Open
@rafbiels

Description

@rafbiels

Describe the bug

The extensions documentation mandates:
https://github.com/intel/llvm/blob/b91d3e2be018c4bf55a4612b074a1d6214828c8b/sycl/doc/extensions/README-process.md

Each extension also has a feature-test macro, which is the same as the extension's name, except it uses all upper case.

as also encouraged by the SYCL 2020 specification:
https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#_feature_test_macros

Vendors are encouraged to group a related set of extensions together into a "feature" and to predefine a feature-test macro when the implementation supports the extensions in that feature. The feature-test macro should have the following form to ensure it is unique: SYCL_EXT_<vendorstring>_<featurename>.

However, the bfloat16 extension does not look to have such a macro:
https://github.com/intel/llvm/blob/b91d3e2be018c4bf55a4612b074a1d6214828c8b/sycl/doc/extensions/supported/sycl_ext_oneapi_bfloat16.asciidoc

To reproduce

No response

Environment

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingconfirmedspec extensionAll issues/PRs related to extensions specifications

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions