[SYCL RT][Coverity] Copy instead of move

[AlexeySachkov]

See Coverity issues at https://scan.coverity.com/projects/intel-llvm?tab=overview

CID 489796:

Coverity complains that the last call of IsMatchingPlatform should use std::move to pass Platform, but we should probably just accept it as const & in the lambda

llvm/sycl/source/detail/platform_impl.cpp

Lines 103 to 115 in 6d5fe22

	auto IsMatchingOpenCL = [](platform Platform, const std::string_view name) {
	const bool HasNameMatch = Platform.get_info<info::platform::name>().find(
	name) != std::string::npos;
	const auto Backend = detail::getSyclObjImpl(Platform)->getBackend();
	const bool IsMatchingOCL = (HasNameMatch && Backend == backend::opencl);
	if (detail::ur::trace(detail::ur::TraceLevel::TRACE_ALL) && IsMatchingOCL) {
	std::cout << "SYCL_UR_TRACE: " << name
	<< " OpenCL platform found but is not compatible." << std::endl;
	}
	return IsMatchingOCL;
	};
	return IsMatchingOpenCL(Platform, "NVIDIA CUDA") ||
	IsMatchingOpenCL(Platform, "AMD Accelerated Parallel Processing");

CID 489974:

sycl_device within the lambda should be moved

llvm/sycl/source/detail/device_impl.cpp

Lines 139 to 145 in 6d5fe22

	std::vector<device> res;
	std::for_each(SubDevices.begin(), SubDevices.end(),
	[&res, this](const ur_device_handle_t &a_ur_device) {
	device sycl_device = detail::createSyclObjFromImpl<device>(
	MPlatform->getOrMakeDeviceImpl(a_ur_device));
	res.push_back(sycl_device);
	});

CID 490149:

push_back into Composites

llvm/sycl/source/platform.cpp

Lines 110 to 121 in 6d5fe22

	std::vector<device> Composites;
	std::vector<device> Result;
	for (auto &Dev : GPUDevices) {
	if (!Dev.has(sycl::aspect::ext_oneapi_is_component))
	continue;
	auto Composite = Dev.get_info<
	sycl::ext::oneapi::experimental::info::device::composite_device>();
	if (std::find(Composites.begin(), Composites.end(), Composite) ==
	Composites.end())
	Composites.push_back(Composite);
	}

CID 490211:

llvm/sycl/source/detail/scheduler/commands.cpp

Lines 1317 to 1320 in 6d5fe22

	UnmapEventImpl->setHandle(UREvent);
	std::swap(MAllocaCmd->MIsActive, MAllocaCmd->MLinkedAllocaCmd->MIsActive);
	EventImpls.clear();
	EventImpls.push_back(UnmapEventImpl);

CID 490242:

llvm/sycl/source/detail/split_string.hpp

Lines 30 to 36 in 6d5fe22

	if (Start < End) {
	std::string LastSubStr(str.substr(Start, End - Start));
	// In case str has a delimeter at the end, the substring will be empty, so
	// we shouldn't add it to the final vector
	if (!LastSubStr.empty())
	Result.push_back(LastSubStr);
	}

CID 490405:

llvm/sycl/source/handler.cpp

Lines 1402 to 1408 in 6d5fe22

	auto EventImpl = detail::getSyclObjImpl(Event);
	// We could not wait for host task events in backend.
	// Adding them as dependency to enable proper scheduling.
	if (EventImpl->isHost()) {
	depends_on(EventImpl);
	}
	impl->MEventsWaitWithBarrier.push_back(EventImpl);

CID 490430:

llvm/sycl/source/detail/composite_device/composite_device.cpp

Lines 26 to 27 in 6d5fe22

	auto Composite = D.get_info<info::device::composite_device>();
	Composites.insert(Composite);

CID 512042:

Note that multiple ext_oneapi_get_info overloads are affected

llvm/sycl/source/kernel.cpp

Line 138 in 6d5fe22

return impl->ext_oneapi_get_info<Param>(Queue, WG);

CID 521997:

llvm/sycl/source/kernel_bundle.cpp

Lines 525 to 530 in 6d5fe22

	std::vector<device> UniqueDevices =
	sycl::detail::removeDuplicateDevices(Devices);
	kernel_bundle_impl &sourceImpl = *getSyclObjImpl(SourceKB);
	std::shared_ptr<kernel_bundle_impl> KBImpl = sourceImpl.compile_from_source(
	UniqueDevices, BuildOptions, LogPtr, RegisteredKernelNames);
	auto result = sycl::detail::createSyclObjFromImpl<obj_kb>(KBImpl);

CID 525242, 525254:

AsyncHandler and Devices could be moved

llvm/sycl/source/detail/context_impl.cpp

Line 35 in 6d5fe22

: MOwnedByRuntime(true), MAsyncHandler(AsyncHandler), MDevices(Devices),

CID 526323

llvm/sycl/source/handler.cpp

Lines 2469 to 2471 in 6d5fe22

	auto E = AuxHandler.finalize();
	if (EventNeeded)
	CGH.depends_on(E);

CID 526341

llvm/sycl/source/handler.cpp

Lines 2487 to 2489 in 6d5fe22

	auto E = CGH.finalize();
	if (!InOrder)
	PostProcessHandler.depends_on(E);

CID 527582, 527595:

Ctx and Devs could be moved

llvm/sycl/source/detail/kernel_bundle_impl.hpp

Line 115 in 6d5fe22

: MContext(Ctx), MDevices(Devs), MState(bundle_state::executable) {

CID 527597:

llvm/sycl/source/detail/scheduler/commands.cpp

Line 3803 in 6d5fe22

MNodes(Nodes) {}

CID 528701:

llvm/sycl/source/detail/platform_impl.cpp

Line 146 in 6d5fe22

Platforms.push_back(Platform);

llvm/sycl/source/detail/platform_impl.cpp

Line 158 in 6d5fe22

Platforms.push_back(Platform);