Merge pull request #26 from intersystems/november-2023-review

Fix for 2023.1

Author: isc-tleavitt

CHANGELOG.md

@@ -5,11 +5,15 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [2.1.4] - Unreleased
+## [3.0.0] - 2023-12-01
+
+### Changed
+- #25: As a consequence of this change, the minimum supported platform version is 2019.1.
 
 ### Fixed
 - #18: EOL normalization in coverage.list
 - #19: Update CI to latest IRIS community (and corresponding test updates)
+- #25: Fix so the tool works on 2023.1
 
 ## [2.1.3] - 2022-03-30
 - Last released version before CHANGELOG existed.

README.md

@@ -1,18 +1,17 @@
-[![Build Status](https://travis-ci.com/intersystems/TestCoverage.svg?branch=master)](https://travis-ci.com/intersystems/TestCoverage) [![codecov](https://codecov.io/gh/intersystems/TestCoverage/branch/master/graph/badge.svg)](https://codecov.io/gh/intersystems/TestCoverage)
+[![codecov](https://codecov.io/gh/intersystems/TestCoverage/branch/master/graph/badge.svg)](https://codecov.io/gh/intersystems/TestCoverage)
 [![Quality Gate Status](https://community.objectscriptquality.com/api/project_badges/measure?project=intersystems_iris_community%2FTestCoverage&metric=alert_status)](https://community.objectscriptquality.com/dashboard?id=intersystems_iris_community%2FTestCoverage) 
 
-# Unit Test Coverage for ObjectScript
+# Unit Test Coverage for InterSystems ObjectScript
 
 Run your typical ObjectScript %UnitTest tests and see which lines of your code are executed. Includes Cobertura-style reporting for use in continuous integration tools.
 
 ## Getting Started
 
-Note: a minimum platform version of Caché/Ensemble 2016.2 is required.
-This tool will also work on any version of InterSystems IRIS.
+Note: a minimum platform version of InterSystems IRIS® data platform 2019.1 is required.
 
 ### Installation: ZPM
 
-If you already have the [ObjectScript Package Manager](https://openexchange.intersystems.com/package/ObjectScript-Package-Manager-2), installation is as easy as:
+If you already have the [InterSystems Package Manager](https://openexchange.intersystems.com/package/InterSystems-Package-Manager-1), installation is as easy as:
 ```
 zpm "install testcoverage"
 ```
@@ -63,7 +62,7 @@ zw ##class(TestCoverage.Utils).GrantSQLReadPermissions("_PUBLIC")
 ## User Guide
 
 ### Running Tests with Coverage
-Generally speaking, set `^UnitTestRoot`, and then call `##class(TestCoverage.Manager).RunTest()` the same you would call `##class(%UnitTest.Manager).RunTest()`. For more information on InterSystems' %UnitTest framework, see the [tutorial](https://docs.intersystems.com/latest/csp/docbook/DocBook.UI.Page.cls?KEY=TUNT) and/or the [class reference for %UnitTest.Manager](https://docs.intersystems.com/latest/csp/documatic/%25CSP.Documatic.cls?PAGE=CLASS&LIBRARY=%25SYS&CLASSNAME=%25UnitTest.Manager).
+Generally speaking, set `^UnitTestRoot`, and then call `##class(TestCoverage.Manager).RunTest()` the same you would call `##class(%UnitTest.Manager).RunTest()`. For more information on InterSystems' %UnitTest framework, see the [tutorial](https://docs.intersystems.com/irislatest/csp/docbook/DocBook.UI.Page.cls?KEY=TUNT) and/or the [class reference for %UnitTest.Manager](https://docs.intersystems.com/irislatest/csp/documatic/%25CSP.Documatic.cls?PAGE=CLASS&LIBRARY=%25SYS&CLASSNAME=%25UnitTest.Manager).
 
 The "userparam" argument can be used to pass information about code coverage data collection. For example:
 
@@ -134,7 +133,7 @@ We use [SemVer](http://semver.org/) for versioning. For the versions available,
 
 ## Authors
 
-* **Tim Leavitt** - *Initial implementation* - [timleavitt](http://github.com/timleavitt)
+* **Tim Leavitt** - *Initial implementation* - [timleavitt](http://github.com/timleavitt) / [isc-tleavitt](http://github.com/isc-tleavitt)
 
 See also the list of [contributors](https://github.com/intersystems/TestCoverage/contributors) who participated in this project.
 

cls/TestCoverage/Data/Aggregate/ByCodeUnit.cls

@@ -50,7 +50,7 @@ Storage Default
 <IdLocation>^TestCoverage.Data.Agg.ByCUD</IdLocation>
 <IndexLocation>^TestCoverage.Data.Agg.ByCUI</IndexLocation>
 <StreamLocation>^TestCoverage.Data.Agg.ByCUS</StreamLocation>
-<Type>%Library.CacheStorage</Type>
+<Type>%Storage.Persistent</Type>
 }
 
 }

cls/TestCoverage/Data/Aggregate/ByRun.cls

@@ -43,7 +43,7 @@ Storage Default
 <IdLocation>^TestCoverage.Data.Agg.ByRunD</IdLocation>
 <IndexLocation>^TestCoverage.Data.Agg.ByRunI</IndexLocation>
 <StreamLocation>^TestCoverage.Data.Agg.ByRunS</StreamLocation>
-<Type>%Library.CacheStorage</Type>
+<Type>%Storage.Persistent</Type>
 }
 
 }

cls/TestCoverage/Data/CodeSubUnit.cls

@@ -32,7 +32,7 @@ Storage Default
 <IdLocation>^TestCoverage.Data.CodeUnitC("SubUnits")</IdLocation>
 <IndexLocation>^TestCoverage.Data.CodeSubUnitI</IndexLocation>
 <StreamLocation>^TestCoverage.Data.CodeSubUnitS</StreamLocation>
-<Type>%Library.CacheStorage</Type>
+<Type>%Storage.Persistent</Type>
 }
 
 }

cls/TestCoverage/Data/CodeSubUnit/Method.cls

@@ -56,7 +56,7 @@ Storage Default
 </Value>
 </Data>
 <DefaultData>MethodDefaultData</DefaultData>
-<Type>%Library.CacheStorage</Type>
+<Type>%Storage.Persistent</Type>
 }
 
 }

cls/TestCoverage/Data/CodeUnit.cls

@@ -488,7 +488,7 @@ Storage Default
 <IdLocation>^TestCoverage.Data.CodeUnitD</IdLocation>
 <IndexLocation>^TestCoverage.Data.CodeUnitI</IndexLocation>
 <StreamLocation>^TestCoverage.Data.CodeUnitS</StreamLocation>
-<Type>%Library.CacheStorage</Type>
+<Type>%Storage.Persistent</Type>
 }
 
 }

cls/TestCoverage/Data/CodeUnitMap.cls

@@ -153,7 +153,7 @@ Storage Default
 <IdLocation>^TestCoverage.Data.CodeUnitMapD</IdLocation>
 <IndexLocation>^TestCoverage.Data.CodeUnitMapI</IndexLocation>
 <StreamLocation>^TestCoverage.Data.CodeUnitMapS</StreamLocation>
-<Type>%Library.CacheStorage</Type>
+<Type>%Storage.Persistent</Type>
 }
 
 }

cls/TestCoverage/Data/Coverage.cls

@@ -160,11 +160,11 @@ Storage Default
 </Data>
 <DataLocation>^TestCoverage.Data.CoverageD</DataLocation>
 <DefaultData>CoverageDefaultData</DefaultData>
-<Description></Description>
 <IdLocation>^TestCoverage.Data.CoverageD</IdLocation>
 <IndexLocation>^TestCoverage.Data.CoverageI</IndexLocation>
 <StreamLocation>^TestCoverage.Data.CoverageS</StreamLocation>
-<Type>%Library.CacheStorage</Type>
+<Type>%Storage.Persistent</Type>
 }
 
 }
+

cls/TestCoverage/Data/Run.cls

@@ -132,7 +132,7 @@ ClassMethod MapRunCoverage(pRunIndex As %Integer) As %Status
 				"	AND oldMetric.element_key = map.ToLine "_
 				"WHERE source.Run = ? "_
 				"	AND source.Ignore = 0"_
-				"	AND source.Calculated = 0"_
+				"	AND source.Calculated = 0 "_
 				"GROUP BY target.ID,map.ToLine"
 
 			#dim tResult As %SQL.StatementResult
@@ -187,7 +187,8 @@ Storage Default
 <IdLocation>^TestCoverage.Data.RunD</IdLocation>
 <IndexLocation>^TestCoverage.Data.RunI</IndexLocation>
 <StreamLocation>^TestCoverage.Data.RunS</StreamLocation>
-<Type>%Library.CacheStorage</Type>
+<Type>%Storage.Persistent</Type>
 }
 
 }
+

cls/TestCoverage/Manager.cls

@@ -8,7 +8,7 @@ Include (%occErrors, %syPidtab, TestCoverage)
 /// </example>
 /// <br />
 /// For use in code based on a known (pre-loaded) unit test package, see documentation for <method>RunAllTests</method>. This also serves as a useful example for how to pass other related user parameters.
-Class TestCoverage.Manager Extends TestCoverage.ManagerBase
+Class TestCoverage.Manager Extends %UnitTest.Manager
 {
 
 /// Level of detail at which test coverage is tracked.