feature/azure-ad-change-provider #8612
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdurand
requested changes
May 14, 2025
html/pfappserver/root/src/views/Configuration/sources/_components/FormTypeAzureAD.vue
Outdated
Show resolved
Hide resolved
html/pfappserver/root/src/views/Configuration/sources/_components/FormTypeAzureAD.vue
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fdurand
force-pushed
the
feature/azure-ad-change-provider
branch
from
b4ea32b to
f01194b
Compare
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR makes Azure AD graph and OAuth URLs configurable by replacing hardcoded Microsoft URLs with configurable fields. This allows for custom Azure AD endpoints or sovereign cloud deployments.
- Replaces hardcoded
user_groups_urlandtoken_urlfields with configurablegraph_urlandoauth_urlfields - Updates the RADIUS configuration generation to use the configurable OAuth URL
- Provides an upgrade script to migrate existing configurations
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/pf/Authentication/Source/AzureADSource.pm | Replaces hardcoded URLs with configurable graph_url and oauth_url fields |
| lib/pf/services/manager/radiusd_child.pm | Updates RADIUS config to use configurable OAuth URL from source |
| html/pfappserver/root/src/views/Configuration/sources/_components/FormTypeAzureAD.vue | Updates Vue form to use new graph_url and oauth_url fields |
| html/pfappserver/lib/pfappserver/Form/Config/Source/AzureAD.pm | Updates form definition with new configurable URL fields |
| html/pfappserver/root/src/views/Configuration/sources/_components/index.js | Exports new form group components for graph and OAuth URLs |
| addons/upgrade/to-15.0-azure-ad.pl | Migration script to convert existing user_groups_url to graph_url |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the AzureAD graph and oauth urls to be configurable.
Issue
fixes #8607
Delete branch after merge
YES
Checklist
(REQUIRED) - [yes, no or n/a]
NEWS file entries
Enhancements