-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Description
With release 10.7.0 of firebase-ios-sdk the auth module gained the ability to set the full name for sign in with apple: https://firebase.google.com/support/release-notes/ios#authentication_7
The OAuth provider likely needs an extension to accept the new parameter (hopefully optional...at least at the javascript layer here) and then call the new API signature in the underlying firebase-ios-sdk
Likely location to add new parameter for the full name in the Apple OAuth credential creation:
static credential(token, secret) { | |
return { | |
token, | |
secret, | |
providerId, | |
}; |
Likely location to swap out the current more generic OAuthProvider call for the apple-specific one mentioned here firebase/firebase-ios-sdk#4393 (comment):
react-native-firebase/packages/auth/ios/RNFBAuth/RNFBAuthModule.m
Lines 1349 to 1351 in ff32fd3
credential = [FIROAuthProvider credentialWithProviderID:provider | |
IDToken:authToken | |
rawNonce:authTokenSecret]; |
PRs welcome! Confirmed that it is tested and working locally critical...
As mentioned in #4046