fix(firestore-stripe-payments): fixed bug when creating a checkout session in setup mode

Author: dackers86

firestore-stripe-payments/functions/__tests__/tests/checkoutsessions/createCheckoutSession.test.ts

@@ -66,6 +66,52 @@ describe('createCheckoutSession', () => {
       expect(success_url).toBe('http://test.com/success');
     });
 
+    test('should setup a future payment with mode:setup', async () => {
+      const collection = firestore.collection('customers');
+
+      const customer: DocumentData = await waitForDocumentToExistInCollection(
+        collection,
+        'email',
+        user.email
+      );
+
+      /** Define params */
+      const client = 'web';
+      const mode = 'setup';
+      const success_url = 'http://test.com/success';
+      const cancel_url = 'http://test.com/cancel';
+      const payment_method_types = ['card'];
+
+      const checkoutSessionCollection = collection
+        .doc(customer.doc.id)
+        .collection('checkout_sessions');
+
+      const checkoutSessionDocument: DocumentReference =
+        await checkoutSessionCollection.add({
+          client: 'web',
+          mode: 'setup',
+          success_url: 'http://test.com/success',
+          cancel_url: 'http://test.com/cancel',
+          payment_method_types,
+        });
+
+      const customerDoc = await waitForDocumentToExistWithField(
+        checkoutSessionDocument,
+        'created'
+      );
+
+      const result = customerDoc.data();
+
+      expect(result.client).toBe(client);
+      expect(result.mode).toBe(mode);
+      expect(result.success_url).toBe(success_url);
+      expect(result.cancel_url).toBe(cancel_url);
+      expect(result.payment_method_types).toEqual(payment_method_types);
+      expect(result.sessionId).toBeDefined();
+      expect(url).toBeDefined();
+      expect(result.created).toBeDefined();
+    });
+
     test.skip('throws an error when success_url has not been provided', async () => {});
 
     test.skip('throws an error when cancel_url has not been provided', async () => {});

firestore-stripe-payments/functions/src/index.ts

@@ -104,6 +104,26 @@ exports.createCustomer = functions.auth
     });
   });
 
+function generateLineItems(
+  line_items: Stripe.Checkout.SessionCreateParams.LineItem[],
+  price: string,
+  quantity: number
+): Stripe.Checkout.SessionCreateParams.LineItem[] {
+  if (line_items) {
+    return line_items;
+  }
+
+  if (price && quantity)
+    return [
+      {
+        price,
+        quantity,
+      },
+    ];
+
+  return [];
+}
+
 /**
  * Create a CheckoutSession or PaymentIntent based on which client is being used.
  */
@@ -185,14 +205,7 @@ exports.createCheckoutSession = functions
           shipping_rates,
           customer,
           customer_update,
-          line_items: line_items
-            ? line_items
-            : [
-                {
-                  price,
-                  quantity,
-                },
-              ],
+          line_items: generateLineItems(line_items, price, quantity),
           mode,
           success_url,
           cancel_url,
@@ -205,6 +218,7 @@ exports.createCheckoutSession = functions
         if (payment_method_types) {
           sessionCreateParams.payment_method_types = payment_method_types;
         }
+
         if (mode === 'subscription') {
           sessionCreateParams.payment_method_collection =
             payment_method_collection;
@@ -244,15 +258,17 @@ exports.createCheckoutSession = functions
         }
         if (promotion_code) {
           sessionCreateParams.discounts = [{ promotion_code }];
-        } else {
+        } else if (mode !== 'setup') {
           sessionCreateParams.allow_promotion_codes = allow_promotion_codes;
         }
         if (client_reference_id)
           sessionCreateParams.client_reference_id = client_reference_id;
+
         const session = await stripe.checkout.sessions.create(
           sessionCreateParams,
           { idempotencyKey: context.params.id }
         );
+
         await snap.ref.set(
           {
             client,