-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Feature(UI): bulk remove models loras #8659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature(UI): bulk remove models loras #8659
Conversation
Implements a comprehensive bulk deletion feature for the model manager that allows users to select and delete multiple models, LoRAs, and embeddings at once. Key changes: Frontend: - Add multi-selection state management to modelManagerV2 slice - Update ModelListItem to support Ctrl/Cmd+Click multi-selection with checkboxes - Create ModelListHeader component showing selection count and bulk actions - Create BulkDeleteModelsModal for confirming bulk deletions - Integrate bulk delete UI into ModelList with proper error handling - Add API mutation for bulk delete operations Backend: - Add POST /api/v2/models/i/bulk_delete endpoint - Implement BulkDeleteModelsRequest and BulkDeleteModelsResponse schemas - Handle partial failures with detailed error reporting - Return lists of successfully deleted and failed models This feature significantly improves user experience when managing large model libraries, especially when restructuring model storage locations. Fixes issue where users had to delete models individually after moving model files to new storage locations.
- Added proper error serialization using serialize-error for better error logging - Explicitly defined BulkDeleteModelsResponse type instead of relying on generated schema reference
- Reordered imports to follow conventional grouping (external, internal, then third-party utilities) - Added type assertion for error serialization to satisfy TypeScript - Extracted inline event handler into named callback function for better readability
|
I did some quick testing of this and it works as advertised. Certainly makes it much easier to do bulk deletions. I have a couple of suggestions for the UI:
Two frontend checks are failing, but look easily fixed. Could you look into this? |
|
Love this! |
…1CV37qYSq2sFP94tNrrfmN
…tions menu - Added select-all checkbox in navigation header with indeterminate state support - Replaced single delete button with actions dropdown menu for future extensibility - Made checkboxes always visible instead of conditionally showing on selection - Moved model filtering logic to ModelListNavigation for select-all functionality - Improved UX by showing selection state for filtered models only
|
pls merge this |
lstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as advertised

Summary
This PR implements a comprehensive bulk deletion feature for the Model Manager, allowing users to select and delete multiple models, LoRAs, and embeddings at once.
Key Features:
Backend Changes:
Frontend Changes:
This significantly improves UX when managing large model libraries, especially when restructuring storage locations.
Related Issues / Discussions
Addresses the pain point where users had to delete models individually after moving model files to new storage locations.
#6240
#6749
QA Instructions
Merge Plan
No special considerations needed. Can be merged after review.
Checklist
Screenshot:
