Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): append newChild if parent node doesn't match with patched node #6141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(runtime): append newChild if parent node doesn't match with patched node #6141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/runtime/dom-extras.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,11 @@ const patchInsertBefore = (HostElementPrototype: HTMLElement) => {
});
if (found) return newChild;
}
// If currentChild's parent is not the same node with the patched node, append newChild to patched node
const parentNode = (currentChild as d.PatchedSlotNode)?.__parentNode;
if (parentNode && !this.isSameNode(parentNode)) {
return this.appendChild(newChild);
}
return (this as d.RenderNode).__insertBefore(newChild, currentChild);
};
};
Expand Down